We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
similar like #93 but for recv_data.
Current h3 return Bytes but poll_data signature use impl Buf, it's hard for outside return owned concrete type without pay copy using Buf#bytes().
impl Buf
Buf#bytes()
d is Bytes.
d
h3/h3/src/frame.rs
Line 116 in dbf2523
h2 crates return Bytes, not impl Buf, it's good.
pub async fn data(&mut self) -> Option<Result<Bytes, crate::Error>> { crate::poll_fn(move |cx| self.poll_data(cx)).await }
send_data should support generic over T, but should we also use generic on recv_data?
send_data
recv_data
The text was updated successfully, but these errors were encountered:
Well, it's seems Bytes use shadow copy buf.map(|mut f| f.copy_to_bytes(f.remaining()))
buf.map(|mut f| f.copy_to_bytes(f.remaining()))
Sorry, something went wrong.
No branches or pull requests
similar like #93 but for recv_data.
Current h3 return Bytes but poll_data signature use
impl Buf
, it's hard for outside return owned concrete type without pay copy usingBuf#bytes()
.d
is Bytes.h3/h3/src/frame.rs
Line 116 in dbf2523
h2 crates return Bytes, not
impl Buf
, it's good.send_data
should support generic over T, but should we also use generic onrecv_data
?The text was updated successfully, but these errors were encountered: