Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow merging two Extensions maps #525

Closed
jplatte opened this issue Feb 21, 2022 · 3 comments · Fixed by #546
Closed

Allow merging two Extensions maps #525

jplatte opened this issue Feb 21, 2022 · 3 comments · Fixed by #546

Comments

@jplatte
Copy link
Contributor

jplatte commented Feb 21, 2022

Motivation: tokio-rs/axum#770

Prior art: The anymap crates allows this through map1.extend(map2.into_raw()) (AFAICT, haven't tested)
@jplatte jplatte changed the title Allow merging two Extensions Allow merging two Extensions maps Feb 21, 2022
@jplatte
Copy link
Contributor Author

jplatte commented Mar 1, 2022

Seems like this isn't actually needed for that axum feature.

@jplatte jplatte closed this as completed Mar 1, 2022
@davidpdrsn davidpdrsn mentioned this issue Apr 19, 2022
Merged
@jplatte
Copy link
Contributor Author

jplatte commented Apr 19, 2022 •
edited
Loading

We're back to wanting this in axum 😄

tokio-rs/axum#950 (comment)

@jplatte jplatte reopened this Apr 19, 2022
@jplatte
Copy link
Contributor Author

jplatte commented Apr 19, 2022

I'll create a PR for this.

@jplatte jplatte mentioned this issue Apr 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Extensions::extend jplatte/http
1 participant
@jplatte