Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http1_writev config for Server #1527

Closed
seanmonstar opened this issue Jun 1, 2018 · 0 comments
Closed

Add http1_writev config for Server #1527

seanmonstar opened this issue Jun 1, 2018 · 0 comments
Labels
A-server Area: server. C-performance Category: performance. This is making existing behavior go faster. E-easy Effort: easy. A task that would be a great starting point for a new contributor.

Comments

@seanmonstar
Copy link
Member

There is an http1_writev config option in the client to disable writev usage internally. While the default is to use auto-detection of writev, the detection must happen on every connection, and for shorter lived connections, it'd be better to configure it off from the start.

This issue is just to add a same kind of config for the server side, by adding hyper::server::conn::Http::http1_writev(enabled: bool). This can trivially be backported for 0.11.

@seanmonstar seanmonstar added A-server Area: server. C-performance Category: performance. This is making existing behavior go faster. E-easy Effort: easy. A task that would be a great starting point for a new contributor. labels Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-server Area: server. C-performance Category: performance. This is making existing behavior go faster. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Development

No branches or pull requests

1 participant