Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the examples for 0.13 #1849

Closed
seanmonstar opened this issue Jul 9, 2019 · 2 comments · Fixed by #1874
Closed

Update the examples for 0.13 #1849

seanmonstar opened this issue Jul 9, 2019 · 2 comments · Fixed by #1874
Labels
A-docs Area: documentation. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Milestone

Comments

@seanmonstar
Copy link
Member

Most of the examples/*.rs files still need to be updated to work with std::future::Future. Most can be more easily written using #[tokio::main], like in this example.

@seanmonstar seanmonstar added E-easy Effort: easy. A task that would be a great starting point for a new contributor. A-docs Area: documentation. labels Jul 9, 2019
@seanmonstar seanmonstar added this to the 0.13 milestone Jul 9, 2019
@liufuyang
Copy link
Contributor

Can I try update a simple example? Looks like you already got the hello example updated, right?
https://github.com/hyperium/hyper/blob/master/examples/hello.rs

And I should try further update it to use #[tokio::main] ? :)

@liufuyang
Copy link
Contributor

I made a simple change like this: #1852
let me know whether that is the right thing to do :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants