Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split the client::conn types into version-specific modules #2842

Closed
seanmonstar opened this issue May 20, 2022 · 1 comment · Fixed by #2906
Closed

Split the client::conn types into version-specific modules #2842

seanmonstar opened this issue May 20, 2022 · 1 comment · Fixed by #2906
Assignees
@seanmonstar
Labels
A-client Area: client. C-feature Category: feature. This is adding a new feature. E-hard Effort: hard. Likely requires a deeper understanding of how hyper's internals work.
Milestone
1.0 RC1

Comments

@seanmonstar
Copy link
Member

The client::conn types, SendRequest and Connection, should get version-specific types in submodules http1 and http2.
@seanmonstar seanmonstar added A-client Area: client. C-feature Category: feature. This is adding a new feature. E-hard Effort: hard. Likely requires a deeper understanding of how hyper's internals work. labels May 20, 2022
@seanmonstar seanmonstar added this to the 1.0 milestone May 20, 2022
@seanmonstar seanmonstar moved this to Todo in hyper 1.0 Jun 15, 2022
@seanmonstar seanmonstar self-assigned this Jun 15, 2022
@seanmonstar seanmonstar moved this from Todo to In Progress in hyper 1.0 Jun 15, 2022
@seanmonstar seanmonstar mentioned this issue Jul 1, 2022
Merged
@seanmonstar seanmonstar linked a pull request Jul 20, 2022 that will close this issue
feat(client): introduce version-specific client modules #2906
Merged
@seanmonstar
Copy link
Member Author

Done in #2906.

Repository owner moved this from In Progress to Done in hyper 1.0 Jul 20, 2022
@seanmonstar seanmonstar mentioned this issue Dec 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanmonstar seanmonstar

Labels
A-client Area: client. C-feature Category: feature. This is adding a new feature. E-hard Effort: hard. Likely requires a deeper understanding of how hyper's internals work.
Projects
No open projects
hyper 1.0
Status: Done
Milestone
1.0 RC1
Development

Successfully merging a pull request may close this issue.

feat(client): introduce version-specific client modules hyperium/hyper
1 participant
@seanmonstar