-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHANGELOG doesn't explain what happened to hyper::Client
or HttpConnector
#3450
Comments
The documentation still refers to the I've been trying to upgrade I'm unsure what to do. The new client is labeled "legacy", and I'd need a non-trivial amount of redesign to integrate with it. Are there plans to introduce a new |
The 0.14 client also has a generic body type. |
True, it did. The default for 0.14 worked for me with both |
I think that my main point of confusion is due to:
It's not immediately obvious what should be used in its place. @simbleau For
|
The CHANGELOG mentions that |
This is very helpful... Let me see if I hit another brick wall. +1! |
There's also https://hyper.rs/guides/1/upgrading/, which while a bit bare, tries to gather all the pain points that the CHANGELOG doesn't seem to address. Anything specific that is hard to find, we can add to that guide. |
It would be nice if it were mentioned that It was easy for me to miss this when converting IO traits from Tower to hyper. I wasn't expecting it to go the other way. |
Answering to myself in case it helps others: I used - .body(Body::empty())?;
+ .body(String::new())?; It's somewhat of a minor annoyance that the body response type is per-client. Ideally, these would be per-request. Different call sites have different needs, despite sharing the same client instance. |
Version
1.0
Description
It's pretty much impossible to update hyper/http to 1.0 for some complex projects that relied heavily on the implementation of Client/HttpConnector since it's not documented how to replace the functionality in the CHANGELOG.
See awslabs/aws-lambda-rust-runtime#737 + awslabs/aws-lambda-rust-runtime#740
The text was updated successfully, but these errors were encountered: