Skip to content

Commit 207577c

Browse files
authored
chore(test): Refactor default stubs test (#2310)
1 parent fda1b26 commit 207577c

File tree

3 files changed

+11
-18
lines changed

3 files changed

+11
-18
lines changed

tests/default_stubs/Cargo.toml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,10 @@ name = "default_stubs"
77
[dependencies]
88
tokio = {version = "1.0", features = ["macros", "rt-multi-thread", "net"]}
99
tokio-stream = {version = "0.1", features = ["net"]}
10-
rand = "0.9"
1110
tonic = {path = "../../tonic"}
1211

12+
[dev-dependencies]
13+
rand = "0.9"
14+
1315
[build-dependencies]
1416
tonic-build = {path = "../../tonic-build" }

tests/default_stubs/src/lib.rs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,12 @@
1-
#![allow(unused_imports)]
2-
3-
mod test_defaults;
4-
51
use std::pin::Pin;
6-
use tokio_stream::{Stream, StreamExt};
2+
use tokio_stream::Stream;
73
use tonic::{Request, Response, Status, Streaming};
84

95
tonic::include_proto!("test");
106
tonic::include_proto!("test_default");
117

128
#[derive(Debug, Default)]
13-
struct Svc;
9+
pub struct Svc;
1410

1511
#[tonic::async_trait]
1612
impl test_server::Test for Svc {

tests/default_stubs/src/test_defaults.rs renamed to tests/default_stubs/tests/default.rs

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,15 @@
1-
#![allow(unused_imports)]
2-
3-
use crate::test_client::TestClient;
4-
use crate::*;
5-
use rand::Rng as _;
6-
use std::env;
7-
use std::fs;
1+
use default_stubs::test_client::TestClient;
2+
use default_stubs::*;
83
use std::net::SocketAddr;
94
use tokio::net::TcpListener;
5+
use tokio_stream::{Stream, StreamExt};
106
use tonic::transport::Channel;
117
use tonic::transport::Server;
128

13-
#[cfg(test)]
149
fn echo_requests_iter() -> impl Stream<Item = ()> {
1510
tokio_stream::iter(1..usize::MAX).map(|_| ())
1611
}
1712

18-
#[cfg(test)]
1913
async fn test_default_stubs(
2014
mut client: TestClient<Channel>,
2115
mut client_default_stubs: TestClient<Channel>,
@@ -100,7 +94,6 @@ async fn test_default_stubs_uds() {
10094
test_default_stubs(client, client_default_stubs).await;
10195
}
10296

103-
#[cfg(test)]
10497
async fn run_services_in_background() -> (SocketAddr, SocketAddr) {
10598
let svc = test_server::TestServer::new(Svc {});
10699
let svc_default_stubs = test_default_server::TestDefaultServer::new(Svc {});
@@ -132,8 +125,10 @@ async fn run_services_in_background() -> (SocketAddr, SocketAddr) {
132125
(addr, addr_default_stubs)
133126
}
134127

135-
#[cfg(all(test, not(target_os = "windows")))]
128+
#[cfg(not(target_os = "windows"))]
136129
async fn run_services_in_background_uds() -> (String, String) {
130+
use rand::Rng as _;
131+
use std::{env, fs};
137132
use tokio::net::UnixListener;
138133

139134
let svc = test_server::TestServer::new(Svc {});

0 commit comments

Comments
 (0)