Skip to content

Commit 3d84669

Browse files
committed
added support to EC keys
Signed-off-by: Yu Juncen <yu745514916@live.com>
1 parent e188521 commit 3d84669

File tree

1 file changed

+82
-13
lines changed
  • tonic/src/transport/service

1 file changed

+82
-13
lines changed

tonic/src/transport/service/tls.rs

Lines changed: 82 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -188,21 +188,15 @@ mod rustls_keys {
188188
use crate::transport::service::tls::TlsError;
189189
use crate::transport::Identity;
190190

191-
fn load_rustls_private_key(
191+
pub(crate) fn load_rustls_private_key(
192192
mut cursor: std::io::Cursor<&[u8]>,
193193
) -> Result<PrivateKey, crate::Error> {
194-
// First attempt to load the private key assuming it is PKCS8-encoded
195-
if let Ok(mut keys) = rustls_pemfile::pkcs8_private_keys(&mut cursor) {
196-
if let Some(key) = keys.pop() {
197-
return Ok(PrivateKey(key));
198-
}
199-
}
200-
201-
// If it not, try loading the private key as an RSA key
202-
cursor.set_position(0);
203-
if let Ok(mut keys) = rustls_pemfile::rsa_private_keys(&mut cursor) {
204-
if let Some(key) = keys.pop() {
205-
return Ok(PrivateKey(key));
194+
while let Ok(Some(item)) = rustls_pemfile::read_one(&mut cursor) {
195+
match item {
196+
rustls_pemfile::Item::RSAKey(key)
197+
| rustls_pemfile::Item::PKCS8Key(key)
198+
| rustls_pemfile::Item::ECKey(key) => return Ok(PrivateKey(key)),
199+
_ => continue,
206200
}
207201
}
208202

@@ -245,3 +239,78 @@ mod rustls_keys {
245239
}
246240
}
247241
}
242+
243+
#[cfg(test)]
244+
mod tests {
245+
use std::io::Cursor;
246+
247+
// generated by: openssl ecparam -keygen -name 'prime256v1'
248+
const SIMPLE_EC_KEY: &str = r#"-----BEGIN EC PARAMETERS-----
249+
BggqhkjOPQMBBw==
250+
-----END EC PARAMETERS-----
251+
-----BEGIN EC PRIVATE KEY-----
252+
MHcCAQEEICIDyh40kMVWGDAYr1gXnMfeMeO3zXYigOaWrg5SNB+zoAoGCCqGSM49
253+
AwEHoUQDQgAEacJyVg299dkPTzUaMbOmACUfF67yp+ZrDhXVjn/5WxBAgjcmFBHg
254+
Tw8dfwpMzaJPXX5lWYzP276fcmbRO25CXw==
255+
-----END EC PRIVATE KEY-----"#;
256+
257+
// generated by: openssl genpkey -algorithm rsa
258+
const SIMPLE_PKCS8_KEY: &str = r#"-----BEGIN PRIVATE KEY-----
259+
MIICdwIBADANBgkqhkiG9w0BAQEFAASCAmEwggJdAgEAAoGBAKHkX1YIvqOIAllD
260+
5fKcIxu2kYjIxxAAQrOBRTloGZUKdPFQY1RANB4t/LEaI5/NJ6NK4915pTn35QAQ
261+
zHJl+X4rNFMgVt+o/nY40PgrQxyyv5A0/URp+iS8Yn3GKt3q6p4zguiO9uNXhiiD
262+
b+VKIFRDm4bHR2yM7pNJ0kMdoattAgMBAAECgYAMpw6UaMaNfVnBpD7agT11MwWY
263+
zShRpdOQt++zFuG49kJBgejhcssf+LQhG0vhd2U7q+S3MISrTSaGpMl1v2aKR/nV
264+
G7X4Bb6X8vrVSMrfze2loT0aNri9jKDZkD/muy6+9JkhRa03NOdhDdseokmcqF3L
265+
xsU4BUOOFYb23ycoeQJBANOGxbZu/3BqsPJMQmXWo1CXuaviZ83lTczPtrz9mJVl
266+
Zs/KmGnJ8I2Azu/dlYXsHRvbIbqA93l1M3GnsWl5IxsCQQDD7hKvOY6qzUNyj+R4
267+
vul/3xaqjiTj59f3jN7Fh6+9AY+WfvEkWfyUUAXY74z43wBgtORfMXnZnjFO96tJ
268+
sswXAkBDYDtb19E/cox4MTg5DfwpMJrwmAYufCqi4Uq4uiI++/SanVKc57jaqbvA
269+
hZkZ9lJzTAJbULcDFgTT3/FPwkkfAkEAqbSDMIzdGuox2n/x9/f8jcpweogmQdUl
270+
xgCZUGSnfkFk2ojXW5Ip6Viqx+0toL6fOCRWjnFvRmPz958kGPCqPwJBAID4y7XV
271+
peOO6Yadu0YbSmFNluRebia6410p5jR21LhG1ty2h22xVhlBWjOC+TyDuKwhmiYT
272+
ed50S3LR1PWt4zE=
273+
-----END PRIVATE KEY-----"#;
274+
275+
// generated by: openssl genrsa
276+
const SIMPLE_RSA_KEY: &str = r#"-----BEGIN RSA PRIVATE KEY-----
277+
MIIEogIBAAKCAQEAoEILGds1/RGBHT7jM4R+EL24sQ6Bsn14GgTHc7WoZ7lainEH
278+
H/n+DtHCYUXYyJnN5AMIi3pkigCP1hdXXBQga3zs3lXoi/mAMkT6vjuqQ7Xg5/95
279+
ABx5Ztyy25mZNaXm77glyAzSscKHxWYooXVJYG4C3SGuBJJ1zVjxen6Rkzse5Lpr
280+
yZOUUeqeV3M6KbJ/dkR37HFQVwmlctQukFnb4kozFBQDDnkXi9jT/PH00g6JpW3z
281+
YMzdMq2RMadJ0dzYv62OtdtqmQpVz0dRu/yODV4DkhrWwgPRj2uY4DnYthzILESB
282+
x41gxHj+jqo6NW+C+0fr6uh2CXtD0p+ZVANtBQIDAQABAoIBAE7IaOCrLV1dr5WL
283+
BvKancbpHdSdBxGSMOrJkqvFkCZ9ro8EhbYolcb/Q4nCZpInWlpPS3IWFzroj811
284+
6BJyKoXtAh1DKnE1lNohowrGFiv3S7uBkiCF3wC8Wokud20yQ9dxNdGkzCdrNIfM
285+
cwj8ubfYHTxMhFnnDlaG9R98/V/dFy0FLxL37eMP/heMbcwKKm9P/G2FqvuCn8a4
286+
FoPbAfvaR64IGCybjoiTjUD7xMHIV4Gr5K07br2TzG2zVlFTacoqXyGBbVVy+ibt
287+
QMh0sn+rMkAy+cFse+yCYZeAFa4FzwGz43sdFviU7uvLG7yXpvZ+uDACFzxlxUVg
288+
v57r1cECgYEA1MMJEe6IunDUyuzRaFNTfQX16QcAv/xLN/1TtVB3HUX5p2bIZKDr
289+
XEl0NCVOrCoz5RsYqbtGmp8B4Yxl3DeX+WeWeD9/f2ZTVGWyBx1N6dZ5hRsyfzG/
290+
xVBUqYxkChjXQ20cNtf8u7JKdnVjOJen9M92nXhFRTwgH83Id4gPp70CgYEAwNN8
291+
lvVJnd05ekyf1qIKOSyKiSGnGa5288PpqsjYMZisXy12y4n8cK2pX5Z5PICHeJVu
292+
K99WdTtO7Q4ghCXRB1jR5pTd4/3/3089SQyDnWz9jlA3pGWcSLDTB1dBJXpMQ6yG
293+
cR2dX5hPDNIdKsc+9Bl/OF5PScvGVUYv4SLF6ukCgYAVhh2WyNDgO6XrWYXdzgA2
294+
N7Im/uReh8F8So57W0aRmZCmFMnVFEp7LZsp41RQKnzRgqo+EYoU/l0MWk27t4wS
295+
WR5pz9KwKsPnV9poydgl/eKRSq0THQ9PgM7v0BoWw2iTk6g1DCivPFw4G6wL/5uo
296+
MozHZXFsjaaaUREktokO6QKBgC3Dg7RILtqaoIOYH+9OseJz4cU+CWyc7XpZKuHv
297+
nO/YbkCAh8syyojrjmEzUz66umwx+t3KubhFBSxZx/nVB9EYkWiKOEdeBxY2tjLa
298+
F3qLXXojK7GGtBrEbLE3UizU47jD/3xlLO59NXWzgFygwR4p1vnH2EWJaV7fs4lZ
299+
OWPRAoGAL0nX0vZ0N9qPETiQan1uHjKYuuFiSP+cwRXVSUYIQM9qDRlKG9zjugwO
300+
az+B6uiR4TrgbwG+faCQwcGk9B8QbcoIb8IigwrWe3XpVaEtcsqFORX0r+tJNDoY
301+
I0O2DOQVPKSK2N5AZzXY4IkybWTV4Yxc7rdXEO3dOOpHGKbpwFQ=
302+
-----END RSA PRIVATE KEY-----"#;
303+
304+
#[test]
305+
fn test_parse_ec_key() {
306+
for (n, key) in [SIMPLE_EC_KEY, SIMPLE_PKCS8_KEY, SIMPLE_RSA_KEY]
307+
.iter()
308+
.enumerate()
309+
{
310+
let c = Cursor::new(key.as_bytes());
311+
let key = super::rustls_keys::load_rustls_private_key(c);
312+
313+
assert!(key.is_ok(), "at the {}-th case", n);
314+
}
315+
}
316+
}

0 commit comments

Comments
 (0)