Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect default initial_connection_window_size/initial_stream_window_size value in doc #1126

Open
yuhao-su opened this issue Oct 28, 2022 · 0 comments

Comments

@yuhao-su
Copy link

yuhao-su commented Oct 28, 2022

Bug Report

The doc states the default size of initial_connection_window_size/initial_stream_window_size will be set to 65535.
initial_stream_window_size
initial_connection_window_size
initial_stream_window_size
initial_connection_window_size

The code in h2 shows the default size it sets is 1024 * 1024 for Server and 1024 * 1024*5/1024 * 1024*2 (unless adaptive_window was set to true)
https://github.com/hyperium/hyper/blob/81e25fa868c86e4ea81d5a96fdca497a4b1ab3c1/src/proto/h2/server.rs#L36
https://github.com/hyperium/hyper/blob/81e25fa868c86e4ea81d5a96fdca497a4b1ab3c1/src/proto/h2/client.rs#L37

Version

tokio: 0.80
hyper: 0.14.20

Platform

Darwin Kernel Version 21.6.0 and also ubuntu20

@yuhao-su yuhao-su changed the title Incorrect default initial_connection_window_size value in doc Incorrect default initial_connection_window_size/initial_stream_window_size value in doc Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant