Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transport): Remove support for OpenSSL #141

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Conversation

jen20
Copy link
Contributor

@jen20 jen20 commented Nov 14, 2019

This pull request removes support for OpenSSL now that the interop tests can run using Rustls, as discussed in Discord.

@jen20 jen20 force-pushed the jen20/remove-ssl branch 2 times, most recently from 4d1a67f to daa31f7 Compare November 15, 2019 12:10
@jen20 jen20 marked this pull request as ready for review November 15, 2019 12:12
@jen20
Copy link
Contributor Author

jen20 commented Nov 15, 2019

@LucioFranco This changes the required checks since interop can now be done as a standard matrix build. Could you update in the repo settings?

Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

@LucioFranco LucioFranco changed the title Remove support for OpenSSL fix(transport): Remove support for OpenSSL Nov 15, 2019
@LucioFranco LucioFranco merged commit 8506050 into master Nov 15, 2019
@LucioFranco LucioFranco deleted the jen20/remove-ssl branch November 15, 2019 12:30
@LucioFranco
Copy link
Member

@jen20 I also removed all the required checks for now.

rabbitinspace pushed a commit to satelit-project/tonic that referenced this pull request Jan 1, 2020
BREAKING CHANGE: Remove support for OpenSSL within the transport.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants