Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated API #1455

Closed
tottoto opened this issue Aug 8, 2023 · 3 comments · Fixed by #1458
Closed

Remove deprecated API #1455

tottoto opened this issue Aug 8, 2023 · 3 comments · Fixed by #1458

Comments

@tottoto
Copy link
Collaborator

tottoto commented Aug 8, 2023

Feature Request

Crates

  • tonic
  • tonic-build

Motivation

Simplifies implementations.

Proposal

Warning
This proposal contains API breaking changes.

There are some deprecated APIs in tonic projects. In this proposal, the assumed version is 0.9.2.

deprecated api deprecated at alternative api
tonic::service::interceptor_fn 0.5.1 tonic::service::interceptor
tonic::service::interceptor::InterceptorFn 0.5.1 tonic::service::interceptor::InterceptorLayer
tonic::metadata::MetadataValue::try_from_bytes 0.7.2 TryFrom
tonic::metadata::MetadataValue::from_shared 0.7.2 TryFrom
tonic::metadata::MetadataValue::<Ascii>::from_str 0.7.2 TryFrom, FromStr
tonic_build::client::generate 0.8.3 tonic_build::CodeGenBuilder::generate_client
tonic_build::server::generate 0.8.3 tonic_build::CodeGenBuilder::generate_server

The latest deprecation among these APIs is tonic-build 0.8.3 released on November 29, 2022. Also, since there has been corresponding alternative APIs, I think that there has been sufficient period to migrate them.

Alternatives

Maintains these APIs until it becomes necessary to remove them for designs or other reasons.

@LucioFranco
Copy link
Member

Yeah, I think it would be good to remove these API's for the next breaking release.

@tottoto
Copy link
Collaborator Author

tottoto commented Aug 9, 2023

Thanks for your review. I'll work on this.

@LucioFranco
Copy link
Member

I think release wise I may go ahead soon and make a point release since I believe what we have on master now is non-breaking (I checked via cargo-semver-checks but I also need to review the code). Once that is done, we can then do a breaking release with these api changes and some other changes include.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants