Endpoint.connect() with TLS fails with InvalidDNSNameError

[corhere]

Bug Report

Version

tonic v0.1.0
tonic-build v0.1.0

Platform

Darwin x86_64

Crates

webpki v0.21.0

Description

Creating a channel by calling connect() on an Endpoint configured with a TLS config fails with the error

    Error(hyper::Error(Connect, InvalidDNSNameError))

unless the domain_name option on the ClientTlsConfig is set. Contrary to the docs, the domain_name option is used (and required) even when the rustls_client_config option is set on the config.

The inner InvalidDNSNameError comes from the webpki crate, returned at this line:

tonic/tonic/src/transport/service/tls.rs

Line 88 in 5fc6762

let dns = DNSNameRef::try_from_ascii_str(self.domain.as_str())?.to_owned();

When the ClientTlsConfig builds a TlsConnector, the entire connection URI string is used as the domain name if the domain name has not been set on the config.

tonic/tonic/src/transport/channel/tls.rs

Lines 83 to 86 in 5fc6762

	let domain = match &self.domain {
	None => uri.to_string(),
	Some(domain) => domain.clone(),
	};

I would expect the domain_name option to actually be optional, and for connections to succeed in the common case when the host component of the connection URI matches the domain name for TLS SNI.

[LucioFranco]

@corhere thanks for writing this up! If I understand correctly you are suggesting that we use uri.host() instead of uri.to_string()?

[corhere]

@LucioFranco that is correct

[LucioFranco]

@corhere I think I got a fix up #244 here, would you be able to confirm this works for you? If it does, I can put a release out this week.

[corhere]

@LucioFranco that fix works for me. Thank you very much for the quick response!

[LucioFranco]

v0.1.1 is out with this fix.