Support retrieve name of NamedService by instance

[tisonkun]

Feature Request

Crates

tonic

Motivation

When I'm trying to retrieve name of health service, it's impossible since the exact type consist an inner struct. Although I can still copy the name string literally and fallback to set_service_status interface, it would be reasonable to retrieve the name of NamedService by instance.

Proposal

I'll submit a patch and it should simply add a getter.

Alternatives

N/A

[LucioFranco]

Could you explain more your use case and why the current way of getting the name doesn't work? I would imagine it still possible to use the const field from the trait without a method.

[tisonkun]

I would imagine it still possible

That would be nice. Could you share a code snippet how to?

So far, base on #930 I can write as below (src):

let (mut health_reporter, health_server) = tonic_health::server::health_reporter();
let health_server_name = health_server.name();

But I may not a Rust expert and don't know how to access the const field since HealthService is not exported.

[LucioFranco]

Ah okay I see, I think the better route would be to just make HealthService public instead of adding a method to the trait. What do you think?

[tisonkun]

@LucioFranco that's OK for my use case. I'm curious why add a method is a bad idea.

[LucioFranco]

@tisonkun its a duplicate of what you can already do and I'd like to avoid extra stuff we don't need :)

[tisonkun]

@LucioFranco make sense. Let me adjust the PR in this way.

[jctaoo]

My usecase is to bind tonic service to axum router described at #1111 , code like:

    let grpc_route = axum::Router::new()
        .route(
            "/enhance_ws.RealtimeHandler/*rpc",
            axum::routing::any_service(RealtimeHandlerServer::new(grpc_service)),
        )
        .route(
            "/enhance_ws.webhook.WebhookScriptManage/*rpc",
            // format!(WebhookScriptManageServer::),
            axum::routing::any_service(WebhookScriptManageServer::new(web_hook_service)),
        )
        .layer(from_fn(|req, next| grpc_auth_layer(req, next, token)))
        .with_state(app_state.clone());

if it's possible to retrieve name of service, I can do something like:

.route(
            format!("{}/*rpc", WebhookScriptManageServer::name),
            axum::routing::any_service(WebhookScriptManageServer::new(web_hook_service)),
)

and it's also useful in binding dynamic service to route.