Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Field in Redis notification #962

Closed
sapiderman opened this issue Dec 14, 2022 · 3 comments
Closed

Missing Field in Redis notification #962

sapiderman opened this issue Dec 14, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@sapiderman
Copy link
Contributor

Describe the bug

  1. On notification, the message and alerts are missing some useful info in the URL field.
  2. It becomes unclear which probe caused the notification

To Reproduce
Config to reproduce the behavior:

notifications:
  - id: id-desktop
    type: desktop
  - id: id-smtp
    type: smtp
    data:
      hostname: smtp.mysserver.com
      port: 2525
      username: usser
      password: password
      recipients: ['me@myserver.com']

  - id: id-teams
    type: teams
    data:
      url: https://mycompany.webhook.office.com/webhookb2/12345-1234-1234

probes:
  - id: id-redis
    name: redis-monitor
    description: testing redis
    interval: 10
    redis: 
      - host: 172.17.0.1
        port: 6380
    incidentThreshold: 3
    recoveryThreshold: 3
    alerts:
      - assertion: response.status != 200
        message: redis disconnected!

Expected behavior

  1. Redis URI or probe-id should be displayed
  2. No empty field in the notification messages

Screenshots
Teams Notification
image

SMTP Notification
image

Desktop (please complete the following information):

  • OS: PopOS! 22.04 LTS
  • Version: 1.14.1
@sapiderman sapiderman added the bug Something isn't working label Dec 14, 2022
@sapiderman sapiderman self-assigned this Dec 14, 2022
@sapiderman
Copy link
Contributor Author

sapiderman commented Dec 16, 2022

So this turned out to be a simple problem, with a not-simple fix.

Root cause is that some of the probes have url, some has host some has both. This info need to be extracted (and parsed). Another solution maybe is not showing the url in the notification but just the probe.id

@guillaumemeyer
Copy link

probe.id would be fine, as long as we have a way to identify the source from the notification message.

@sapiderman
Copy link
Contributor Author

Issue should be fixed after #1080... closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants