Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Typescript build output to ES6 Modules #2553

Closed
jmrossy opened this issue Jul 21, 2023 · 1 comment
Closed

Convert Typescript build output to ES6 Modules #2553

jmrossy opened this issue Jul 21, 2023 · 1 comment
Assignees

Comments

@jmrossy
Copy link
Contributor

jmrossy commented Jul 21, 2023

Description

The build settings for the monorepo JS packages don't support tree-shaking, which how bundlers drop code apps don't use. Meaning every consumer of the utils/core/sdk packages will bundle every lib we use, every contract factory, and all our code into their app, even if they don't use parts of it. Currently our bundle contribution is 1.5Mb plus all our transitive lib deps. Not horrible, but problematic as we start adding libs for more protocols. To fix this we'd need to change our TS and package.json settings to produce more modern build output.

Requirements

  • Builds output both commonJS and ES6 module output
  • Package.json files are updated to properly reference the different types
  • The output libs work with most popular bundlers/frameworks including webpack 5, rollup, next.js, esbuild, etc.
  • Test projects are created to ensure the libs work and don't regress
@jmrossy
Copy link
Contributor Author

jmrossy commented Mar 7, 2024

Closing as dupe of #1354

@jmrossy jmrossy closed this as not planned Won't fix, can't repro, duplicate, stale Mar 7, 2024
@github-project-automation github-project-automation bot moved this from Next Sprint to Done in Hyperlane Tasks Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants