Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(secret): remove python LP Validator/Verifier secret keys from repository #2017

Closed
izuru0 opened this issue May 11, 2022 · 0 comments · Fixed by #2033
Closed

feat(secret): remove python LP Validator/Verifier secret keys from repository #2017

izuru0 opened this issue May 11, 2022 · 0 comments · Fixed by #2033
Labels
enhancement New feature or request

Comments

@izuru0
Copy link
Contributor

izuru0 commented May 11, 2022

Is your feature request related to a problem? Please describe.

keys for authentication for python LPs are stored in these directories, but it is discouraged to have such files included in the repository:

https://github.com/hyperledger/cactus/tree/main/packages-python/cactus_validator_socketio_indy/sample-CA
https://github.com/hyperledger/cactus/tree/main/packages-python/cactus_validator_socketio_iroha/sample-CA

Describe the solution you'd like

Generate these files during build process and remove them from repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant