feat(fabric-connector): add getChainInfo, improve getBlock output #3298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outSH
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ctor-fabric/src/test/typescript/integration/fabric-v2-2-x/query-system-chain-methods.test.ts
Dismissed
Show dismissed
Hide dismissed
outSH
force-pushed
the
persistence_plugin_fabric_connector_changes_pr
branch
from
07e3bb6
to
3ac2cbb
Compare
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Jun 11, 2024
- Rewrite fabric persistence plugin to match persistence ethereum plugin methods and behavior. - Change DB schema for persistence. - Add tests and sample data to the new plugin. Add them to project CI. Depends on hyperledger-cacti#3298 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
5 tasks
|
As per @petermetz suggestion in https://github.com/hyperledger/cacti/pull/3308#discussion_r1637090342, I've rebased with main and changed the following:
|
outSH
force-pushed
the
persistence_plugin_fabric_connector_changes_pr
branch
from
3ac2cbb
to
2e1dada
Compare
@outSH Thank you very much! |
- Add new method `getChainInfo` for quering chain information from qscc. - Add `GetChainInfoEndpointV1` to allow calling `getChainInfo` remotely. - Refactor `getBlock` so it can return same custom block formats as `WatchBlocks`. Default remains the same (full decode block). BREAKING CHANGE: It accepts `type` instead of `skipDecode` flag. - Move common block formatting logic to `cacti-block-formatters.ts`. - Add tests for new features. Move test common to quering `qscc` to single file to increase CI speed. Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
petermetz
force-pushed
the
persistence_plugin_fabric_connector_changes_pr
branch
from
2e1dada
to
9b2d4a8
Compare
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Jul 18, 2024
- Rewrite fabric persistence plugin to match persistence ethereum plugin methods and behavior. - Change DB schema for persistence. - Add tests and sample data to the new plugin. Add them to project CI. Depends on hyperledger-cacti#3298 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Jul 18, 2024
- Rewrite fabric persistence plugin to match persistence ethereum plugin methods and behavior. - Change DB schema for persistence. - Add tests and sample data to the new plugin. Add them to project CI. Depends on hyperledger-cacti#3298 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Jul 18, 2024
- Rewrite fabric persistence plugin to match persistence ethereum plugin methods and behavior. - Change DB schema for persistence. - Add tests and sample data to the new plugin. Add them to project CI. Depends on hyperledger-cacti#3298 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Jul 18, 2024
- Rewrite fabric persistence plugin to match persistence ethereum plugin methods and behavior. - Change DB schema for persistence. - Add tests and sample data to the new plugin. Add them to project CI. Depends on hyperledger-cacti#3298 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
petermetz
pushed a commit
to outSH/cactus
that referenced
this pull request
Jul 18, 2024
- Rewrite fabric persistence plugin to match persistence ethereum plugin methods and behavior. - Change DB schema for persistence. - Add tests and sample data to the new plugin. Add them to project CI. Depends on hyperledger-cacti#3298 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH
added a commit
that referenced
this pull request
Jul 18, 2024
- Rewrite fabric persistence plugin to match persistence ethereum plugin methods and behavior. - Change DB schema for persistence. - Add tests and sample data to the new plugin. Add them to project CI. Depends on #3298 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getChainInfofor quering chain information from qscc.GetChainInfoEndpointV1to allow callinggetChainInforemotely.getBlockso it can return same custom block formats asWatchBlocks. Default remains the same (full decode block). BREAKING CHANGE: It acceptstypeinstead ofskipDecodeflag.cacti-block-formatters.ts.qsccto single file to increase CI speed.Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.