Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] Follow convention of new and into_parts across data model #4360

Open
0x009922 opened this issue Mar 11, 2024 · 1 comment
Open
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@0x009922
Copy link
Contributor

Original proposal from @mversic & #4341 (comment)

The idea is to follow a convention in the data model and all other places across the workspace:

  • We use new as a main method to create structures, usually from internal parts (it is already followed)
  • For a reverse conversion from a structure into its parts, we should use a method named into_parts
@0x009922 0x009922 added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Mar 11, 2024
@mversic
Copy link
Contributor

mversic commented Aug 9, 2024

let's have a separate meeting where we have discuss having data model transparent instead of getter functions

@nxsaken nxsaken added this to Iroha Sep 4, 2024
@nxsaken nxsaken moved this to Backlog in Iroha Sep 4, 2024
@nxsaken nxsaken moved this from Backlog to Work in Progress in Iroha Sep 4, 2024
@nxsaken nxsaken moved this from Work in Progress to Backlog in Iroha Sep 4, 2024
@mversic mversic moved this from Required for MVP to Backlog in Iroha Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

No branches or pull requests

3 participants