Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DID Exchange - Create and send requests against implicit invitations #1174

Merged
merged 4 commits into from
May 17, 2021

Conversation

shaangill025
Copy link
Contributor

closes #1137

Signed-off-by: Shaanjot Gill <shaangill025@users.noreply.github.com>
Signed-off-by: Shaanjot Gill <shaangill025@users.noreply.github.com>
Signed-off-by: Shaanjot Gill <shaangill025@users.noreply.github.com>
@shaangill025
Copy link
Contributor Author

@domwoe Will this work for your use case?

@shaangill025 shaangill025 marked this pull request as ready for review May 13, 2021 19:27
@domwoe
Copy link

domwoe commented May 15, 2021

@shaangill025 looks good! However, I went the path to add an additional route because I think it makes sense to return the connection record instead of the request when sending the request over DIDcomm.

@sklump sklump merged commit f15a445 into openwallet-foundation:main May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DID Exchange - Issue with implicit invitations
3 participants