Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger and wallet config updates; add support for transaction author agreements #127

Merged
merged 13 commits into from
Aug 8, 2019

Conversation

andrewwhitehead
Copy link
Contributor

@andrewwhitehead andrewwhitehead commented Aug 7, 2019

  • Add support for transaction author agreements when required by the ledger pool
  • Add --genesis-file config parameter (alternative to --genesis-url)
  • Move ledger and wallet config into common methods
  • Add --replace-public-did config parameter to allow replacement of the wallet public DID at startup
  • Update Docker images to indy-sdk 1.11.0

@codecov-io
Copy link

codecov-io commented Aug 7, 2019

Codecov Report

Merging #127 into master will decrease coverage by 0.74%.
The diff coverage is 47.5%.

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
- Coverage   72.96%   72.21%   -0.75%     
==========================================
  Files         186      188       +2     
  Lines        8000     8180     +180     
==========================================
+ Hits         5837     5907      +70     
- Misses       2163     2273     +110

@swcurran
Copy link
Contributor

swcurran commented Aug 8, 2019

When running the demo on this branch, I get this errors starting up Faber and Alice:

Starting alice...

#7 Provision an agent and wallet, get back configuration details
Alice      | 2019-08-08 16:56:19,483 indy.libindy.native.indy.services.pool.state_proof.node ERROR      src/services/pool/state_proof/node.rs:131 | Unexpected data while parsing Patricia Merkle Trie: Ok(Data(0)): UntrustedRlp { bytes: [128], offset_cache: Cell { value: OffsetCache { index: 18446744073709551615, offset: 0 } }, count_cache: Cell { value: None } }
Alice      | 2019-08-08 16:56:19,500 indy.libindy.native.indy.services.pool.state_proof.node ERROR      src/services/pool/state_proof/node.rs:131 | Unexpected data while parsing Patricia Merkle Trie: Ok(Data(0)): UntrustedRlp { bytes: [128], offset_cache: Cell { value: OffsetCache { index: 18446744073709551615, offset: 0 } }, count_cache: Cell { value: None } }

The demo worked properly, but I think the errors should be looked at since they seem to relate to this change.

@andrewwhitehead
Copy link
Contributor Author

@swcurran I believe that error only shows up with SDK 1.9.0, updating to 1.11.0 fixes it. It doesn't seem to affect the functionality.

Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
…ations

Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
…lace-public-did

Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@andrewwhitehead andrewwhitehead changed the title Adding support for transaction author agreements Ledger and wallet config updates; add support for transaction author agreements Aug 8, 2019
@andrewwhitehead andrewwhitehead marked this pull request as ready for review August 8, 2019 20:12
Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code, ran the demo. All good. Error happening on previous test no longer happening.

Let's get a new release done to PyPi.

@surajsingla333
Copy link

Hello, I want to deploy my Aries-cloud-agent on Sovrin network but I am still getting this error
Exception: Error: 400: Ledger rejected transaction request: client request invalid: InvalidClientTaaAcceptanceError('Txn Author Agreement acceptance is required for ledger with id 1',).
I am using Sovrin Staging net and can see the DID on IndyScan but not able to generate the TAA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants