-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ledger and wallet config updates; add support for transaction author agreements #127
Ledger and wallet config updates; add support for transaction author agreements #127
Conversation
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
==========================================
- Coverage 72.96% 72.21% -0.75%
==========================================
Files 186 188 +2
Lines 8000 8180 +180
==========================================
+ Hits 5837 5907 +70
- Misses 2163 2273 +110 |
When running the demo on this branch, I get this errors starting up Faber and Alice:
The demo worked properly, but I think the errors should be looked at since they seem to relate to this change. |
@swcurran I believe that error only shows up with SDK 1.9.0, updating to 1.11.0 fixes it. It doesn't seem to affect the functionality. |
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
…ations Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
…lace-public-did Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
ba61eb6
to
30f8d8e
Compare
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the code, ran the demo. All good. Error happening on previous test no longer happening.
Let's get a new release done to PyPi.
Hello, I want to deploy my Aries-cloud-agent on Sovrin network but I am still getting this error |
--genesis-file
config parameter (alternative to--genesis-url
)--replace-public-did
config parameter to allow replacement of the wallet public DID at startup