Align OutOfBandManager.receive_invitation with other connection managers #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chumbert
force-pushed
the
oob-connection-manager-api-alignment
branch
from
813d05e
to
76fd6bd
Compare
setup.
* Align `OutOfBandManager.receive_invitation` signature with the
`ConnectionManager.receive_invitation` and
`DIDXManager.receive_invitation`
* rename first parameter to `invitation`
* change return type to `ConnRecord` and leave serialization work
for users of the manager
* Serialize the received `ConnRecord` in
`protocols.out_of_band.v1_0.routes`
* Adapt related tests. `assert
ConnRecord.deserialize(conn_rec)` is dubious as a test assertion but boiled down to `assert conn_rec
is not None`.
* Use this refactoring to reduce branching in mediator connection
handling in `conductor.py`.
Signed-off-by: Clément Humbert <clement.humbert@gmail.com>
chumbert
force-pushed
the
oob-connection-manager-api-alignment
branch
from
76fd6bd
to
f12df9d
Compare
Codecov Report
@@ Coverage Diff @@
## main #1382 +/- ##
==========================================
- Coverage 95.28% 95.27% -0.01%
==========================================
Files 476 476
Lines 29034 29025 -9
==========================================
- Hits 27664 27655 -9
Misses 1370 1370 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring step before proposing changes in mediation connection
setup.
Align
OutOfBandManager.receive_invitationsignature with theConnectionManager.receive_invitationandDIDXManager.receive_invitationinvitationConnRecordand leave serialization workfor users of the manager
Serialize the received
ConnRecordinprotocols.out_of_band.v1_0.routesAdapt related tests.
assert ConnRecord.deserialize(conn_rec)is dubious as a test assertion but boiled down toassert conn_rec is not None.Use this refactoring to reduce branching in mediator connection
handling in
conductor.py.Signed-off-by: Clément Humbert clement.humbert@gmail.com