Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aries 36 and 37 v1, demo/workshop updates to match #164

Merged
merged 7 commits into from
Sep 1, 2019
Merged

Aries 36 and 37 v1, demo/workshop updates to match #164

merged 7 commits into from
Sep 1, 2019

Conversation

sklump
Copy link
Contributor

@sklump sklump commented Aug 30, 2019

incorporating latest available updates from hyperledger/master

@codecov-io
Copy link

Codecov Report

Merging #164 into master will decrease coverage by 1.72%.
The diff coverage is 62.5%.

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
- Coverage   73.45%   71.72%   -1.73%     
==========================================
  Files         188      217      +29     
  Lines        8230     9819    +1589     
==========================================
+ Hits         6045     7043     +998     
- Misses       2185     2776     +591

…review

Signed-off-by: sklump <srklump@hotmail.com>
Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the changes and ran the demo. All good. Still need to run the API demo.

I question if we want to use the temporary names at all. My preference would be that we flag the 0.1 as deprecated as soon as we are comfortable and use the names of the new protocols as they will be in the long run. If there is a name collision between the two protocols, we deal with it on a case by case basis. I would think we tend to backwards compatibility, unless it really screws up the long run handling.

I guess we accept this PR and then follow up quickly to change the names.

@andrewwhitehead andrewwhitehead merged commit a21a51a into openwallet-foundation:master Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants