Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to get and set the credential tagging policy for a cred def ID #185

Merged
merged 4 commits into from
Sep 19, 2019

Conversation

andrewwhitehead
Copy link
Contributor

@andrewwhitehead andrewwhitehead commented Sep 17, 2019

  • Add wallet/tag-policy/{cred_def_id} GET and POST endpoints
  • Avoid republishing a cred def that already exists on the ledger

…ef ID

Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@codecov-io
Copy link

codecov-io commented Sep 17, 2019

Codecov Report

Merging #185 into master will decrease coverage by 0.14%.
The diff coverage is 47.69%.

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
- Coverage   71.75%   71.61%   -0.15%     
==========================================
  Files         218      218              
  Lines        9883     9931      +48     
==========================================
+ Hits         7092     7112      +20     
- Misses       2791     2819      +28

Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tests are passing. Merging.

@swcurran swcurran merged commit 195561e into openwallet-foundation:master Sep 19, 2019
@andrewwhitehead andrewwhitehead deleted the set-tag-policy branch February 29, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants