Reuse credential offers and requests when possible #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asses Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
…tion Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
==========================================
+ Coverage 73.66% 74.74% +1.07%
==========================================
Files 219 219
Lines 10045 10103 +58
==========================================
+ Hits 7400 7551 +151
+ Misses 2645 2552 -93 |
…to manager class Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
sklump
reviewed
Oct 30, 2019
aries_cloudagent/messaging/issue_credential/v1_0/messages/credential_issue.py
Outdated
Show resolved
Hide resolved
sklump
reviewed
Oct 30, 2019
| @@ -73,6 +63,12 @@ def context(self) -> InjectionContext: | |||
|
|
|||
| """ | |||
|
|
|||
| credential_definition_id = credential_proposal.cred_def_id | |||
There was a problem hiding this comment.
The proposal will not include a cred def id in future - rather, an issuer and schema id - so this will need some touching up at that time. Until then, it's fine.
sklump
previously approved these changes
Oct 30, 2019
ianco
previously approved these changes
Oct 30, 2019
swcurran
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds tests and type info to the CredentialManager class, and allows create_offer to be called without a credential proposal.