Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle send timeout in admin websocket #377

Merged

Conversation

andrewwhitehead
Copy link
Contributor

Fixes #366

Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #377 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
- Coverage   89.14%   89.13%   -0.02%     
==========================================
  Files         236      236              
  Lines       11222    11225       +3     
==========================================
+ Hits        10004    10005       +1     
- Misses       1218     1220       +2

Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Ran demos - not sure if that hits websocket transport - perhaps the performance demo?

@swcurran swcurran merged commit d816653 into openwallet-foundation:master Feb 23, 2020
@andrewwhitehead andrewwhitehead deleted the fix/admin-ws-timeout branch February 29, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Websocket "Webhook" not working
3 participants