Isolate anoncreds usage in IndyIssuer and IndyHolder classes #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewwhitehead
force-pushed
the
isolate-creds
branch
from
d3f0cca
to
7f60b75
Compare
|
This pull request introduces 1 alert when merging 7f60b75 into 47d6be5 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #406 +/- ##
==========================================
- Coverage 88.43% 88.09% -0.34%
==========================================
Files 243 245 +2
Lines 11916 11990 +74
==========================================
+ Hits 10538 10563 +25
- Misses 1378 1427 +49 |
sklump
previously approved these changes
Mar 9, 2020
andrewwhitehead
changed the title
|
This pull request introduces 1 alert when merging 95938d1 into 47d6be5 - view on LGTM.com new alerts:
|
andrewwhitehead
force-pushed
the
isolate-creds
branch
from
9ba1cf6
to
d2d0a73
Compare
andrewwhitehead
force-pushed
the
isolate-creds
branch
from
d2d0a73
to
d89710f
Compare
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
andrewwhitehead
force-pushed
the
isolate-creds
branch
from
d89710f
to
b0ccf40
Compare
sklump
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the class to be swapped out for indy-credx.
Probably reduces test coverage because the ledger tests were also testing the issuer code.