Maximum try count for outbound messages #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the base repository with the newest version
Maximum outbound message deliver retry is switched to parametric. Default value was set as 4 and if --max-outbound-retry parameter is provided as an argument its value is set with this argument value. Signed-off-by: Özgür Deniz Günseli <deniz.gunseli@ecospend.com>
denizgunseli
force-pushed
the
feature/max-outbound-retry
branch
from
1b6cfad
to
e8c3329
Compare
|
Looks good, but I can't sync it up with master to merge it. |
Merging with the up-to-date solution
andrewwhitehead
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maximum try count for outbound messages was defined as hardcoded in manager. For any reason, it might be necessary to increase or decrease this parameter.
This value was set as 4 as a defult value in manager and set as a a parameter in config and changes has been made for using this value from settings.