Remove superfluous non revoc intervals #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sklump <srklump@hotmail.com>
…rents are non-revocable credentials: seek and destroy Signed-off-by: sklump <srklump@hotmail.com>
Codecov Report
@@ Coverage Diff @@
## master #699 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 252 252
Lines 13620 13631 +11
=======================================
+ Hits 13482 13493 +11
Misses 138 138 |
Signed-off-by: sklump <srklump@hotmail.com>
|
I have tested this using non-revocable credentials as well as revocable credentials and it works as expected. |
andrewwhitehead
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also a ton of black tweaks arising from the new version.
Addresses #698