Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix shell inconsistency #72

Merged
merged 2 commits into from
Jul 16, 2019
Merged

fix shell inconsistency #72

merged 2 commits into from
Jul 16, 2019

Conversation

nobody4t
Copy link
Contributor

fix the shell inconsistency in the script.

The bash should use instead of sh.
Remove "[[" in the shell syntax which may cause incompatibility issue.

Signed-off-by: dongwangdw xdragon007@gmail.com

Signed-off-by: dongwangdw <xdragon007@gmail.com>
@nobody4t nobody4t mentioned this pull request Jul 16, 2019
@codecov-io
Copy link

Codecov Report

Merging #72 into master will decrease coverage by 0.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   70.67%   70.29%   -0.39%     
==========================================
  Files         176      176              
  Lines        7400     7402       +2     
==========================================
- Hits         5230     5203      -27     
- Misses       2170     2199      +29

Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all the scripts on PWD - all working. Nice.

@swcurran swcurran merged commit 0ee2052 into openwallet-foundation:master Jul 16, 2019
burdettadam pushed a commit to burdettadam/aries-cloudagent-python that referenced this pull request Apr 29, 2021
cjhowland pushed a commit to cjhowland/aries-cloudagent-python that referenced this pull request Aug 31, 2022
…/credential-attachments-issuer

fix: supplement singular
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants