Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for version 0.2.0 release #77

Merged
merged 5 commits into from
Jul 16, 2019
Merged

Prepare for version 0.2.0 release #77

merged 5 commits into from
Jul 16, 2019

Conversation

nrempel
Copy link
Contributor

@nrempel nrempel commented Jul 16, 2019

No description provided.

@nrempel
Add changelog, fix setup.py, downgrade version
b2251c9 
Signed-off-by: Nicholas Rempel <nbrempel@gmail.com>
@codecov-io
Copy link

codecov-io commented Jul 16, 2019 •
edited
Loading

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   70.56%   70.56%           
=======================================
  Files         177      177           
  Lines        7429     7429           
=======================================
  Hits         5242     5242           
  Misses       2187     2187

@nrempel nrempel requested a review from swcurran July 16, 2019 21:16
swcurran
swcurran previously approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Shows the importance of good PR names - what to call them, and what not to call them.

@nrempel
Add more information to CONTRIBUTING.md
ad2ba5e 
Signed-off-by: Nicholas Rempel <nbrempel@gmail.com>
@nrempel
Copy link
Contributor Author

nrempel commented Jul 16, 2019

@swcurran good point, I've updated the contributing instructions as well to reflect that: https://github.com/hyperledger/aries-cloudagent-python/pull/77/files?short_path=6a33714#diff-6a3371457528722a734f3c51d9238c13

@nrempel nrempel requested a review from swcurran July 16, 2019 21:29
swcurran
swcurran approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - perhaps in a future update we can point to good and bad examples of PR names :-)

@nrempel nrempel merged commit 4966609 into openwallet-foundation:master Jul 16, 2019
@nrempel nrempel deleted the 0.2.0 branch July 16, 2019 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swcurran swcurran swcurran approved these changes

@andrewwhitehead andrewwhitehead Awaiting requested review from andrewwhitehead

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nrempel @codecov-io @swcurran