Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(routing): add reconnection parameters to RecipientModuleConfig #1070

Conversation

genaris
Copy link
Contributor

@genaris genaris commented Oct 25, 2022

To be consistent with other parameters in Mediation Recipient module, baseMediatorReconnectionIntervalMs and maximumMediatorReconnectionIntervalMs in AgentConfig are marked as deprecated and added to RecipientModuleConfig.

Default values and reconnection logic remain identical to 0.2.x.

Signed-off-by: Ariel Gentile <gentilester@gmail.com>
@genaris genaris requested a review from a team as a code owner October 25, 2022 01:09
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2022

Codecov Report

Merging #1070 (d5540c3) into main (7f37a62) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1070      +/-   ##
==========================================
+ Coverage   88.22%   88.23%   +0.01%     
==========================================
  Files         680      680              
  Lines       15903    15907       +4     
  Branches     2570     2572       +2     
==========================================
+ Hits        14030    14036       +6     
+ Misses       1865     1863       -2     
  Partials        8        8              
Impacted Files Coverage Δ
packages/core/src/agent/AgentConfig.ts 95.45% <ø> (+6.06%) ⬆️
packages/core/src/agent/AgentModules.ts 100.00% <ø> (ø)
packages/core/src/modules/routing/RecipientApi.ts 61.81% <0.00%> (ø)
.../core/src/modules/routing/RecipientModuleConfig.ts 73.33% <0.00%> (-26.67%) ⬇️
packages/core/src/wallet/IndyWallet.ts 55.80% <0.00%> (+0.37%) ⬆️
packages/core/src/storage/IndyStorageService.ts 95.34% <0.00%> (+0.77%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@genaris genaris changed the title feat(routing): add reconnection parameters to module config feat(routing): add reconnection parameters to RecipientModuleConfig Oct 25, 2022
@genaris genaris enabled auto-merge (squash) October 25, 2022 11:16
@genaris genaris merged commit d4fd1ae into openwallet-foundation:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants