Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose AttachmentData and DiscoverFeaturesEvents #1146

Conversation

genaris
Copy link
Contributor

@genaris genaris commented Dec 7, 2022

Expose AttachmentData and Discover Features events... and some minor housekeeping to remove a few lint warnings.

Signed-off-by: Ariel Gentile gentilester@gmail.com

Signed-off-by: Ariel Gentile <gentilester@gmail.com>
@genaris genaris requested a review from a team as a code owner December 7, 2022 21:27
@genaris genaris changed the title fix: missing exports fix: expose AttachmentData and DiscoverFeaturesEvents Dec 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2022

Codecov Report

Merging #1146 (9aa4cc4) into main (157a357) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1146   +/-   ##
=======================================
  Coverage   88.32%   88.32%           
=======================================
  Files         706      706           
  Lines       16429    16430    +1     
  Branches     2664     2664           
=======================================
+ Hits        14511    14512    +1     
  Misses       1911     1911           
  Partials        7        7           
Impacted Files Coverage Δ
...es/core/src/agent/models/OutboundMessageContext.ts 73.68% <ø> (ø)
packages/core/src/types.ts 100.00% <ø> (ø)
packages/core/src/index.ts 100.00% <100.00%> (ø)
...ckages/core/src/modules/discover-features/index.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TimoGlastra TimoGlastra merged commit e48f481 into openwallet-foundation:main Dec 8, 2022
NB-MikeRichardson added a commit to NB-MikeRichardson/aries-framework-javascript that referenced this pull request Dec 8, 2022
fix: expose AttachmentData and DiscoverFeaturesEvents (openwallet-foundation#1146)
NB-MikeRichardson added a commit to NB-MikeRichardson/aries-framework-javascript that referenced this pull request Dec 8, 2022
fix: expose AttachmentData and DiscoverFeaturesEvents (openwallet-foundation#1146)
@genaris genaris deleted the fix/export-discover-events-and-attachment-data branch January 28, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants