-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support more key types in jws service #1453
Merged
TimoGlastra
merged 7 commits into
openwallet-foundation:main
from
TimoGlastra:feat/jws-service
May 17, 2023
Merged
feat: support more key types in jws service #1453
TimoGlastra
merged 7 commits into
openwallet-foundation:main
from
TimoGlastra:feat/jws-service
May 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1453 +/- ##
==========================================
+ Coverage 85.54% 85.84% +0.29%
==========================================
Files 886 910 +24
Lines 21150 21676 +526
Branches 3635 3709 +74
==========================================
+ Hits 18093 18607 +514
- Misses 2882 2890 +8
- Partials 175 179 +4
|
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
TimoGlastra
force-pushed
the
feat/jws-service
branch
from
May 11, 2023 08:56
9fab261
to
0e4f920
Compare
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
berendsliedrecht
requested changes
May 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of small comments again that should be relatively easy to resolve. Great work Timo!
Signed-off-by: Timo Glastra <timo@animo.id>
berendsliedrecht
approved these changes
May 15, 2023
Signed-off-by: Timo Glastra <timo@animo.id>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this pr is dependant on #1446 and thus should be merged after that PR is merged.This PR refactors the JWK and JWS implementation to have better support for JWK / JWA, and also support more algs/key types in the JWS service. Basically the JWS service now supports all JWKs supported in AFJ, although it's limited by the algs and key types supported by the wallet (for askar we support EdDsa and ES256)