-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Multibase, Multihash and Hashlinks #263
feat: add support for Multibase, Multihash and Hashlinks #263
Conversation
Codecov Report
@@ Coverage Diff @@
## main #263 +/- ##
==========================================
+ Coverage 89.47% 89.64% +0.16%
==========================================
Files 195 198 +3
Lines 3581 3668 +87
Branches 393 406 +13
==========================================
+ Hits 3204 3288 +84
- Misses 377 380 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small suggestions
Although conventional commits allows to use upper case types, I prefer |
Signed-off-by: Berend Sliedrecht <berend@animo.id>
Co-authored-by: Timo Glastra <timo@animo.id> Signed-off-by: Berend Sliedrecht <berend@animo.id>
Co-authored-by: Timo Glastra <timo@animo.id> Signed-off-by: Berend Sliedrecht <berend@animo.id>
Co-authored-by: Timo Glastra <timo@animo.id> Signed-off-by: Berend Sliedrecht <berend@animo.id>
Co-authored-by: Timo Glastra <timo@animo.id> Signed-off-by: Berend Sliedrecht <berend@animo.id>
Signed-off-by: Berend Sliedrecht <berend@animo.id>
65e1649
to
775cc7f
Compare
Signed-off-by: Berend Sliedrecht <berend@animo.id>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. Code is clean, readable, and well-structured 👍 I could resist adding a few suggestions but nothing critical :)
We should rename the files according to a class naming convention at least.
Signed-off-by: berend <berend@animo.id>
Signed-off-by: berend <berend@animo.id>
Signed-off-by: blu3beri <dev@blueberi.nl>
Signed-off-by: blu3beri <dev@blueberi.nl>
Signed-off-by: blu3beri <berend@animo.id>
Implements Multihash, Multibase and Hashlinks.
Adds decoding, encoding and validating for multibase, multihash and hashlinks.
Hashlinks have been implemented accoring to draft-sporny-hashlink-07
The main reason for this implementation is to add multibase for the upcoming did exchange protocol and hashlink for linking credentials to attachments.
Signed-off-by: Berend Sliedrecht berend@animo.id