fix: test failing because of moved import #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Glastra <timo@animo.id>
Codecov Report
@@ Coverage Diff @@
## main #282 +/- ##
=======================================
Coverage 88.76% 88.76%
=======================================
Files 216 216
Lines 3899 3899
Branches 438 438
=======================================
Hits 3461 3461
Misses 438 438 Continue to review full report at Codecov.
|
This was referenced May 19, 2021
jakubkoci
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the failing CI.
The CI jobs are now required so it won't be possible to get bad commits into main
The problem was because I moved
toBeConnectedwith to setup so each test file doesn't have to do it anymore. However this caused (i think?) some cyclic dependencies