Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pack and send message based on DidDoc services #304

Merged
merged 4 commits into from
Jun 22, 2021
Merged

feat: Pack and send message based on DidDoc services #304

merged 4 commits into from
Jun 22, 2021

Conversation

jakubkoci
Copy link
Contributor

Related to #268

@jakubkoci jakubkoci requested a review from a team as a code owner June 3, 2021 10:46
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2021

Codecov Report

Merging #304 (f759f0e) into main (5c16cc1) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
+ Coverage   88.34%   88.39%   +0.05%     
==========================================
  Files         222      223       +1     
  Lines        4031     4043      +12     
  Branches      449      447       -2     
==========================================
+ Hits         3561     3574      +13     
+ Misses        470      469       -1     
Impacted Files Coverage Δ
src/types.ts 100.00% <ø> (ø)
src/agent/Dispatcher.ts 97.29% <100.00%> (+0.23%) ⬆️
src/agent/EnvelopeService.ts 100.00% <100.00%> (ø)
src/agent/MessageSender.ts 100.00% <100.00%> (ø)
src/agent/TransportService.ts 91.66% <100.00%> (-0.65%) ⬇️
src/agent/helpers.ts 100.00% <100.00%> (+7.69%) ⬆️
src/modules/connections/ConnectionsModule.ts 67.60% <100.00%> (ø)
src/modules/routing/RoutingModule.ts 96.66% <100.00%> (ø)
src/modules/proofs/models/RequestedCredentials.ts 72.00% <0.00%> (-28.00%) ⬇️
src/modules/indy/services/IndyHolderService.ts 89.47% <0.00%> (-5.27%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c16cc1...f759f0e. Read the comment docs.

src/agent/TransportService.ts Outdated Show resolved Hide resolved
src/agent/__tests__/MessageSender.test.ts Outdated Show resolved Hide resolved
src/agent/helpers.ts Show resolved Hide resolved
src/agent/Dispatcher.ts Outdated Show resolved Hide resolved
src/agent/EnvelopeService.ts Outdated Show resolved Hide resolved
src/agent/EnvelopeService.ts Outdated Show resolved Hide resolved
src/agent/MessageSender.ts Outdated Show resolved Hide resolved
src/agent/MessageSender.ts Outdated Show resolved Hide resolved
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
…run route

Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
@jakubkoci
Copy link
Contributor Author

@TimoGlastra I think I updated almost everything. As a next step, I'm going to add sendMessage to TransportSession interface allowing us to send a message and do not return the outbound message to inbound transport. I can perhaps replace createOutboundMessage with OutboundMessageContext

Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Great work @jakubkoci :)

I can perhaps replace createOutboundMessage with OutboundMessageContext

Agree

@jakubkoci jakubkoci merged commit 6a26337 into openwallet-foundation:main Jun 22, 2021
if (message.hasReturnRouting(threadId)) {
return await this.messageSender.packMessage(outboundMessage)
const keys = {
recipientKeys: messageContext.senderVerkey ? [messageContext.senderVerkey] : [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW -- what happens when there are no recipient keys

@jakubkoci jakubkoci deleted the multi-transport branch June 24, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants