-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Pack and send message based on DidDoc services #304
feat: Pack and send message based on DidDoc services #304
Conversation
Codecov Report
@@ Coverage Diff @@
## main #304 +/- ##
==========================================
+ Coverage 88.34% 88.39% +0.05%
==========================================
Files 222 223 +1
Lines 4031 4043 +12
Branches 449 447 -2
==========================================
+ Hits 3561 3574 +13
+ Misses 470 469 -1
Continue to review full report at Codecov.
|
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
…run route Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
@TimoGlastra I think I updated almost everything. As a next step, I'm going to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Great work @jakubkoci :)
I can perhaps replace createOutboundMessage with OutboundMessageContext
Agree
if (message.hasReturnRouting(threadId)) { | ||
return await this.messageSender.packMessage(outboundMessage) | ||
const keys = { | ||
recipientKeys: messageContext.senderVerkey ? [messageContext.senderVerkey] : [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW -- what happens when there are no recipient keys
Related to #268