-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add multiple inbound transports #433
feat: add multiple inbound transports #433
Conversation
TimoGlastra
commented
Aug 20, 2021
- add support for multiple inbound transports
- rename all occurrences of transporter to transport
Signed-off-by: Timo Glastra <timo@animo.id>
Codecov Report
@@ Coverage Diff @@
## main #433 +/- ##
==========================================
+ Coverage 85.60% 85.66% +0.06%
==========================================
Files 249 249
Lines 5342 5351 +9
Branches 798 796 -2
==========================================
+ Hits 4573 4584 +11
+ Misses 769 767 -2
Continue to review full report at Codecov.
|
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
@@ -20,8 +20,9 @@ export class WsInboundTransport implements InboundTransporter { | |||
|
|||
this.logger = config.logger | |||
|
|||
this.logger.debug(`Starting HTTP inbound transporter`, { | |||
endpoint: config.getEndpoint(), | |||
const httpEndpoint = config.endpoints.find((e) => e.startsWith('http')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not the most knowledgeable on this subject, but this will also match https. Which might be intended but the log message below is incorrect then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>