Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): d_m invitation parameter and invitation image #456

Conversation

berendsliedrecht
Copy link
Contributor

  • Adds support for the d_m invitation parameter in the url
  • Improved url parsing (with polyfill for React Native)
  • Able to add an image to the invitation

Signed-off-by: Berend Sliedrecht <berend@animo.id>
Signed-off-by: Berend Sliedrecht <berend@animo.id>
@berendsliedrecht berendsliedrecht requested a review from a team as a code owner September 7, 2021 19:41
@genaris
Copy link
Contributor

genaris commented Sep 7, 2021

Nice to have these invitation improvements, and actually I find very useful to have that imageUrl field. Is it part of any Aries RFC or currently a Trinsic-specific feature?

I'm asking this because maybe there are other implementations that use other metadata to make invitations 'user-friendlier' and other fields would be needed to use the framework with them.

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2021

Codecov Report

Merging #456 (1d7390d) into main (f3790c9) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
+ Coverage   85.67%   85.68%   +0.01%     
==========================================
  Files         253      253              
  Lines        5451     5457       +6     
  Branches      839      841       +2     
==========================================
+ Hits         4670     4676       +6     
  Misses        781      781              
Impacted Files Coverage Δ
...onnections/messages/ConnectionInvitationMessage.ts 98.03% <100.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3790c9...1d7390d. Read the comment docs.

@berendsliedrecht
Copy link
Contributor Author

Is it part of any Aries RFC or currently a Trinsic-specific feature?

I found it from decoding the trinsic invitation, but I can take a look if it is specified in any RFC. I will take a look tomorrow and get back to you!

@berendsliedrecht
Copy link
Contributor Author

@genaris I have checked around in the rfcs, but I could not find any other metadata for the invitation. If you have other data we can always discuss that during a working group call. However, we should really keep the invitation as small as possible. A large invitation means a large QRcode which is always annoying :-)

@TimoGlastra
Copy link
Contributor

This is not native to the Aries RFCs but more an non-standard extension that a lot of wallets use (e.g. Lissi, Connect.Me, Trinsic)

Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I think we may get away with using a smaller lib instead of the URL polyfill (e.g. query-string package). But this looks fine to me for now

@TimoGlastra TimoGlastra merged commit f92c322 into openwallet-foundation:main Sep 15, 2021
@berendsliedrecht berendsliedrecht deleted the feature/trinsic-interop branch August 31, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants