Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): using query-string to parse URLs #457

Merged

Conversation

berendsliedrecht
Copy link
Contributor

  • Took the advice of @TimoGlastra ans used query-string for parsing URLs.

Signed-off-by: Berend Sliedrecht <berend@animo.id>
@berendsliedrecht berendsliedrecht requested a review from a team as a code owner September 16, 2021 15:48
@codecov-commenter
Copy link

Codecov Report

Merging #457 (1c6e9cf) into main (f92c322) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #457   +/-   ##
=======================================
  Coverage   85.68%   85.68%           
=======================================
  Files         253      253           
  Lines        5457     5457           
  Branches      841      876   +35     
=======================================
  Hits         4676     4676           
  Misses        781      781           
Impacted Files Coverage Δ
...onnections/messages/ConnectionInvitationMessage.ts 98.03% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f92c322...1c6e9cf. Read the comment docs.

@TimoGlastra TimoGlastra merged commit 78e5057 into openwallet-foundation:main Sep 16, 2021
@berendsliedrecht berendsliedrecht deleted the fix/use-query-string branch August 31, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants