fix(core)!: do not request ping res for connection

[TimoGlastra]

BREAKING CHANGE: a trust ping response will not be requested anymore after completing a connection. This is not required, and also non-standard behaviour. It was also causing some tests to be flaky as response messages were stil being sent after one of the agents had already shut down.

Signed-off-by: Timo Glastra timo@animo.id

Maintainers: Before merging and squashing make sure to copy the BREAKING CHANGE entry to the commit message field, this is needed for automatic tracking of breaking changes

Fixes #515

[TimoGlastra]

@JamesKEbert this has some overlap with the changes in #458 but is only adding the responseRequested property to not request a trust ping response after creating a connection. There is a flaky tests that errors often because a trust ping response is sent after the tests has already been finished. This seemed like the easiest (and correct way) to fix it.

[codecov-commenter]

Codecov Report

Merging #527 (02a7a55) into main (5e9a641) will decrease coverage by 0.20%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main     #527      +/-   ##
==========================================
- Coverage   86.27%   86.06%   -0.21%     
==========================================
  Files         266      266              
  Lines        5762     5762              
  Branches      931      932       +1     
==========================================
- Hits         4971     4959      -12     
- Misses        790      802      +12     
  Partials        1        1              

Impacted Files	Coverage Δ
.../core/src/modules/connections/ConnectionsModule.ts	73.80% <0.00%> (ø)
...ckages/core/src/modules/routing/RecipientModule.ts	63.35% <0.00%> (ø)
.../connections/handlers/ConnectionResponseHandler.ts	100.00% <100.00%> (ø)
.../modules/connections/services/ConnectionService.ts	95.87% <100.00%> (ø)
...s/connections/messages/TrustPingResponseMessage.ts	42.85% <0.00%> (-50.00%)	⬇️
...c/modules/connections/services/TrustPingService.ts	66.66% <0.00%> (-33.34%)	⬇️
...ctions/handlers/TrustPingResponseMessageHandler.ts	71.42% <0.00%> (-28.58%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e9a641...02a7a55. Read the comment docs.