feat: generic attachment handler #578

morrieinmaas · 2021-12-14T13:58:58Z

Adds method getDataAsJson to Attachment data and therefore also to Attachment.data
This return the attachmnt data as JSON if .json or .base64 are present in attachmentdata.
Otherwise it throws an error.

Co-authored-by: annelein anneleinvanreijen@gmail.com

Signed-off-by: morrieinmaas moritz@animo.id

Adds method getDataAsJson to Attachment data and therefore also to Attachment.data This return the attachmnt data as JSON if .json or .base64 are present in attachmentdata. Otherwise it throws an error. Co-authored-by: annelein <anneleinvanreijen@gmail.com> Signed-off-by: morrieinmaas <moritz@animo.id>

morrieinmaas · 2021-12-15T11:33:49Z

closes #548

berendsliedrecht · 2021-12-15T11:40:07Z

packages/core/src/decorators/attachment/Attachment.ts

@@ -45,6 +47,16 @@ export class AttachmentData {
    }
  }

+  public getDataAsJson() {


Would it be a good idea to add a generic here? This would allows us to get the typing from the return type in a nice way without casting.

probably 😅 will have to have a quick read into how that works in TS as I'm a noob.

But not sure as there is no args (input)

not tested but this should work

public getDataAsJson<T>(): T { return json as T }

TimoGlastra

Nice work @morrieinmaas and @Annelein, have a few comments

TimoGlastra · 2021-12-15T11:49:23Z

packages/core/src/decorators/attachment/Attachment.ts

@@ -45,6 +47,16 @@ export class AttachmentData {
    }
  }

+  public getDataAsJson() {
+    if (this.base64 !== null && typeof this.base64 === 'string') {


I would use just this.base64 to also capture base64 being undefined

Suggested change

if (this.base64 !== null && typeof this.base64 === 'string') {

if (this.base64 && typeof this.base64 === 'string') {

TimoGlastra · 2021-12-15T11:50:03Z

packages/core/src/decorators/attachment/Attachment.ts

+  public getDataAsJson() {
+    if (this.base64 !== null && typeof this.base64 === 'string') {
+      return JsonEncoder.fromBase64(this.base64)
+    } else if (this.json !== null) {


same here

Suggested change

} else if (this.json !== null) {

} else if (this.json) {

TimoGlastra · 2021-12-15T11:51:08Z

packages/core/src/decorators/attachment/Attachment.ts

+    } else if (this.json !== null) {
+      return this.json
+    } else {
+      throw new AriesFrameworkError('No attachment data available.')


Maybve we can be a bit more explicit in the error message, as it could be that data is available, just not in the base64 or json fields

No attachment data found in 'json' or 'base64' data fields.

TimoGlastra · 2021-12-15T11:52:00Z

packages/core/src/modules/credentials/messages/IssueCredentialMessage.ts

    // Extract credential from attachment
-    const credentialJson = JsonEncoder.fromBase64(attachment.data.base64)
+    const credentialJson = attachment?.data ? attachment.data.getDataAsJson() : null


Wouldn't this work? (also in the other places)

Suggested change

const credentialJson = attachment?.data ? attachment.data.getDataAsJson() : null

const credentialJson = attachment?.data?.getDataAsJson()

I'll check that

fixed fct declaration and henceforth tests Co-authored-by: annelein <anneleinvanreijen@gmail.com> Signed-off-by: morrieinmaas <moritz@animo.id>

codecov-commenter · 2021-12-15T14:30:21Z

Codecov Report

Merging #578 (2c4c442) into main (3dadfc7) will increase coverage by 0.05%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
+ Coverage   86.33%   86.38%   +0.05%     
==========================================
  Files         286      286              
  Lines        6066     6059       -7     
  Branches      891      893       +2     
==========================================
- Hits         5237     5234       -3     
+ Misses        826      822       -4     
  Partials        3        3

Impacted Files	Coverage Δ
...kages/core/src/decorators/attachment/Attachment.ts	`97.67% <87.50%> (-2.33%)`	⬇️
...les/credentials/messages/IssueCredentialMessage.ts	`100.00% <100.00%> (+4.00%)`	⬆️
...les/credentials/messages/OfferCredentialMessage.ts	`100.00% <100.00%> (+3.44%)`	⬆️
...s/credentials/messages/RequestCredentialMessage.ts	`100.00% <100.00%> (+3.84%)`	⬆️
...src/modules/proofs/messages/PresentationMessage.ts	`100.00% <100.00%> (+4.00%)`	⬆️
...ules/proofs/messages/RequestPresentationMessage.ts	`100.00% <100.00%> (+3.57%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dadfc7...2c4c442. Read the comment docs.

Signed-off-by: annelein <anneleinvanreijen@gmail.com>

berendsliedrecht · 2021-12-15T20:16:33Z

packages/core/src/decorators/attachment/Attachment.ts

@@ -45,6 +47,16 @@ export class AttachmentData {
    }
  }

+  public getDataAsJson<T>(): T {
+    if (this.base64 && typeof this.base64 === 'string') {
+      return JsonEncoder.fromBase64(this.base64)


This must also be casted to T`

berendsliedrecht · 2021-12-15T20:33:34Z

packages/core/src/modules/credentials/messages/IssueCredentialMessage.ts


-    return credentialJson
+    return credentialJson as Cred


This casting removes the null. Is this intentional? If so, could you remove it from the function signature aswell?

hmm... yeah intention is that according the linter type of credentialJson is unknown if I leave out as Cred which 'not assignable to Cred'

basically that's why i had sth along the lines of

const credentialJson = attachment?.data ? attachment.data.getDataAsJson() : null

in the first commit... Again greatful for any help

If we use optional chaining, .? we short circuit to return an undefined. This means that the value we want to return from the function could be undefined.

This could happen if attachment or attachment.data does not exist.

So if we want a 100% to return an object and not null from this function we must check if these two fields exist:

If (attachment?.data) { // some case handling }

After this we 100% have attachment.data to call getDataAsJson() on.

If we do not want to return the object OR null, as the api is right now, we could go back to your ternary expression.

or we use try...catch?

berendsliedrecht · 2021-12-15T20:34:32Z

packages/core/src/modules/credentials/messages/OfferCredentialMessage.ts


-    return credentialOfferJson
+    return credentialOfferJson as CredOffer


Same here. Seems to happen in a couple of places. If something changes, could you change it everywhere?

as above - added this to match the type. Maybe we can remove null from the fct signature as getDataAsJson actually throws an error now if it can't provide data. Again, I'm pretty new to typescript. Thought this would result either in an error or undefined but not null the way it is now. Any help appreciated

Better typing/function signatures Co-authored-by: annelein <anneleinvanreijen@gmail.com> Signed-off-by: morrieinmaas <moritz@animo.id>

Merge branch 'feat/generic-attachment-handler' of github.com:morrieinmaas/aries-framework-javascript into feat/generic-attachment-handler Signed-off-by: morrieinmaas <moritz@animo.id>

morrieinmaas · 2021-12-16T10:22:36Z

@TimoGlastra do you have anymore feedback? Or can we merge this?

TimoGlastra

LGTM! :)

morrieinmaas · 2021-12-16T11:09:18Z

@blu3beri @TimoGlastra merge please

Signed-off-by: morrieinmaas <moritz@animo.id> Co-authored-by: annelein <anneleinvanreijen@gmail.com> Signed-off-by: annelein <anneleinvanreijen@gmail.com>

fix(core): expose record metadata types (openwallet-foundation#556) Signed-off-by: Berend Sliedrecht <berend@animo.id> Co-authored-by: Timo Glastra <timo@animo.id> ci: create non-annotated tags (openwallet-foundation#559) Signed-off-by: Timo Glastra <timo@animo.id> style: non-null assertions and newline import (openwallet-foundation#561) Signed-off-by: Timo Glastra <timo@animo.id> chore: disable unnecessary type check in Dispatcher test (openwallet-foundation#565) Signed-off-by: Jakub Koci <jakub.koci@gmail.com> ci: add continuous deployment scripts (openwallet-foundation#552) Signed-off-by: Timo Glastra <timo@animo.id> feat: expose wallet API (openwallet-foundation#566) This commit also contains the following changes: * Create a master secret when creating a wallet. * Do not delete wallet when shutdown is called on agent. * Expose the whole wallet API, which also contains methods that should be used only inside the framework. We need to improve that in the future. Signed-off-by: Jakub Koci <jakub.koci@gmail.com> BREAKING CHANGE: The agent’s `shutdown` method does not delete the wallet anymore. If you want to delete the wallet, you can do it via exposed wallet API. build: add arm test ledger setup (openwallet-foundation#573) Signed-off-by: Timo Glastra <timo@animo.id> feat: add problem report protocol (openwallet-foundation#560) Signed-off-by: Amit Padmani <amit@northernblock.io> docs: added report problem protocol to README (openwallet-foundation#574) Signed-off-by: Berend Sliedrecht <berend@animo.id> fix: support mediation for connectionless exchange (openwallet-foundation#577) Signed-off-by: Timo Glastra <timo@animo.id> refactor(core): separate logic for inbound plaintext and encrypted message (openwallet-foundation#581) * rename wire message to encrypted message Signed-off-by: Jakub Koci <jakub.koci@gmail.com> feat: generic attachment handler (openwallet-foundation#578) Signed-off-by: morrieinmaas <moritz@animo.id> Co-authored-by: annelein <anneleinvanreijen@gmail.com> refactor: resolve feedback for problem report (openwallet-foundation#584) Signed-off-by: Amit Padmani <amit@northernblock.io> fix(core)!: Improved typing on metadata api (openwallet-foundation#585) Signed-off-by: Berend Sliedrecht <berend@animo.id> BREAKING CHANGE: removed the getAll() function. chore(release): v0.1.0 (openwallet-foundation#571) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> docs(apple-silicon): update OpenSSL instructions (openwallet-foundation#590) * docs(apple-silicon): update openssl install instructions Signed-off-by: Karim Stekelenburg <karim@animo.id> * docs(apple-silicon): add missing 'add to path' commands Signed-off-by: Karim Stekelenburg <karim@animo.id> * docs(apple-silicon): run prettier Signed-off-by: Karim Stekelenburg <karim@animo.id> feat(core): allow to set auto accept connetion exchange when accepting invitation (openwallet-foundation#589) Signed-off-by: Jakub Koci <jakub.koci@gmail.com> feat: ledger connections happen on agent init in background (openwallet-foundation#580) * Connects to ledger on agent init by default, ledger calls will wait for connections to be complete if so * Updated version of indy-sdk-react-native to 0.1.16 Signed-off-by: Patrick Kenyon <treek.kenyon@gmail.com> feat: add generic did resolver (openwallet-foundation#554) * feat: did:key, did:web, did:sov resolver Signed-off-by: Timo Glastra <timo@animo.id> feat: add support for signed attachments (openwallet-foundation#595) Signed-off-by: Timo Glastra <timo@animo.id> BREAKING CHANGE: attachment method `getDataAsJson` is now located one level up. So instead of `attachment.data.getDataAsJson()` you should now call `attachment.getDataAsJson()` build(deps): bump shelljs from 0.8.4 to 0.8.5 (openwallet-foundation#598) Signed-off-by: dependabot[bot] <support@github.com> feat: add didcomm message record (openwallet-foundation#593) Signed-off-by: Timo Glastra <timo@animo.id> fix: disallow usage of global buffer (openwallet-foundation#601) fix: verify jws contains at least 1 signature (openwallet-foundation#600) feat(core): added timeOut to the module level (openwallet-foundation#603) * fix(core): added timeOut to the module level Signed-off-by: Berend Sliedrecht <berend@animo.id> feat: add support for did:peer (openwallet-foundation#608) Signed-off-by: Timo Glastra <timo@animo.id> feat: support new did document in didcomm message exchange (openwallet-foundation#609) * refactor: unify did document services * feat: integrate did resolver with message sender * feat: support new did docoument for msg receiver Signed-off-by: Timo Glastra <timo@animo.id> docs: proofs (openwallet-foundation#564) Signed-off-by: Mostafa <mostafa.youssef@ontario.ca> fix: incorrect encoding of services for did:peer (openwallet-foundation#610) Signed-off-by: Timo Glastra <timo@animo.id> ci: get last alpha package version from npm (openwallet-foundation#611) We currently use the commit number, but this is incorrect as the number will be reset to 0 again when the next minor version is released. Signed-off-by: Timo Glastra <timo@animo.id> chore: regenerate yarn.lock for security updates (openwallet-foundation#616) Signed-off-by: Timo Glastra <timo@animo.id> ci: prepend v to alpha releases for consistency (openwallet-foundation#617) Signed-off-by: Timo Glastra <timo@animo.id> feat: add find and save/update methods to DidCommMessageRepository (openwallet-foundation#620) Signed-off-by: NB-Karim <karim.northernblock@gmail.com> feat: update recursive backoff & trust ping record updates (openwallet-foundation#631) Signed-off-by: James Ebert <jamesebert.k@gmail.com> fix: leading zeros in credential value encoding (openwallet-foundation#632) Signed-off-by: James Ebert <jamesebert.k@gmail.com> feat: indy revocation (prover & verifier) (openwallet-foundation#592) * Added recepientRevocation for createProof Signed-off-by: Patrick Kenyon <treek.kenyon@gmail.com> * Initial revocation functions for getRequestedCredentialsForProofRequest Signed-off-by: Patrick Kenyon <treek.kenyon@gmail.com> * Added option to check for revocation status in getRequestedCredentials Signed-off-by: Patrick Kenyon <treek.kenyon@gmail.com> * sorted transports Signed-off-by: Adam Burdett <burdettadam@gmail.com> * broken message sender tests Signed-off-by: Adam Burdett <burdettadam@gmail.com> * structure fix Signed-off-by: Adam Burdett <burdettadam@gmail.com> * lint import ordering Signed-off-by: Adam Burdett <burdettadam@gmail.com> * if(0) does not work. Signed-off-by: Adam Burdett <burdettadam@gmail.com> * utf-8 decode ws event.data Signed-off-by: Adam Burdett <burdettadam@gmail.com> * indy wallet friendly bits Signed-off-by: Adam Burdett <burdettadam@gmail.com> * correct protocal type Signed-off-by: Adam Burdett <burdettadam@gmail.com> * check invite during init Signed-off-by: Adam Burdett <burdettadam@gmail.com> * id check Signed-off-by: Adam Burdett <burdettadam@gmail.com> * keep sockets with mediators open Signed-off-by: Adam Burdett <burdettadam@gmail.com> * recursive backoff Signed-off-by: Adam Burdett <burdettadam@gmail.com> * timeout Signed-off-by: Adam Burdett <burdettadam@gmail.com> * timeout time Signed-off-by: Adam Burdett <burdettadam@gmail.com> * logger Signed-off-by: Adam Burdett <burdettadam@gmail.com> * propper recursive backoff Signed-off-by: Adam Burdett <burdettadam@gmail.com> * multiple socket timeout support Signed-off-by: Adam Burdett <burdettadam@gmail.com> * Code cleanup Signed-off-by: Patrick Kenyon <treek.kenyon@gmail.com> * Fix tests and types Signed-off-by: Patrick Kenyon <treek.kenyon@gmail.com> * Formatting and type fixes Signed-off-by: Patrick Kenyon <treek.kenyon@gmail.com> * revocation fixes Signed-off-by: Patrick Kenyon <treek.kenyon@gmail.com> * ran prettier Signed-off-by: Patrick Kenyon <treek.kenyon@gmail.com> * chore: add ts ignore until types are updated Signed-off-by: James Ebert <jamesebert.k@gmail.com> * feat: updated tails download to utilize axios and added inline docs Signed-off-by: James Ebert <jamesebert.k@gmail.com> * chore: fixed formatting Signed-off-by: James Ebert <jamesebert.k@gmail.com> * chore: removed husky Signed-off-by: James Ebert <jamesebert.k@gmail.com> * fix: add back husky pre-push Signed-off-by: James Ebert <jamesebert.k@gmail.com> * chore: formatting Signed-off-by: James Ebert <jamesebert.k@gmail.com> * fix: fixed error imports Signed-off-by: James Ebert <jamesebert.k@gmail.com> * chore: resolve dependency loop issues Signed-off-by: James Ebert <jamesebert.k@gmail.com> * chore: formatting Signed-off-by: James Ebert <jamesebert.k@gmail.com> * feature: revocation ledger methods & proof get requested credentials revoked status Signed-off-by: James Ebert <jamesebert.k@gmail.com> * feature: added revocation state creation Signed-off-by: James Ebert <jamesebert.k@gmail.com> * fix: small tweaks and fixes for revocation Signed-off-by: James Ebert <jamesebert.k@gmail.com> * feature: takes into account referent revocation intervals Signed-off-by: James Ebert <jamesebert.k@gmail.com> * chore: cleanup & prettier Signed-off-by: James Ebert <jamesebert.k@gmail.com> * fix: fixed createrevocationstate types & initial rev reg def caching Signed-off-by: James Ebert <jamesebert.k@gmail.com> * chore: formatting Signed-off-by: James Ebert <jamesebert.k@gmail.com> * fix: fixed proofservice test mock Signed-off-by: James Ebert <jamesebert.k@gmail.com> * chore: minor cleanup Signed-off-by: James Ebert <jamesebert.k@gmail.com> * chore: rename indyutilitiesservice Signed-off-by: James Ebert <jamesebert.k@gmail.com> * chore: troubleshooting revocation, added ledger methods for verifying proof of non revocation Signed-off-by: James Ebert <jamesebert.k@gmail.com> * chore: cleanup & credential storage w/revocation Signed-off-by: James Ebert <jamesebert.k@gmail.com> * feat: add download to file method to file system Signed-off-by: Timo Glastra <timo@animo.id> * refactor: use rnfs for react native Signed-off-by: Timo Glastra <timo@animo.id> * chore: cleanup & log adjustments Signed-off-by: James Ebert <jamesebert.k@gmail.com> * chore: formatting Signed-off-by: James Ebert <jamesebert.k@gmail.com> * feat: verify proofs containing proof of non_revocation Signed-off-by: James Ebert <jamesebert.k@gmail.com> * chore: formatting Signed-off-by: James Ebert <jamesebert.k@gmail.com> * chore: update indy-sdk-react-native & indy-sdk types Signed-off-by: James Ebert <jamesebert.k@gmail.com> * chore: adjusts names to be consistent & removing abbreviations Signed-off-by: James Ebert <jamesebert.k@gmail.com> * chore: updated indy-sdk types to fix proof identifier types Signed-off-by: James Ebert <jamesebert.k@gmail.com> * fix: indyverifierservice prototype pollution Signed-off-by: James Ebert <jamesebert.k@gmail.com> Co-authored-by: Patrick Kenyon <treek.kenyon@gmail.com> Co-authored-by: Adam Burdett <burdettadam@gmail.com> Co-authored-by: Timo Glastra <timo@animo.id> fix: check for "REQNACK" response from indy ledger (openwallet-foundation#626) Signed-off-by: annelein <anneleinvanreijen@gmail.com> fix: credential preview attributes mismatch schema attributes (openwallet-foundation#625) Signed-off-by: annelein <anneleinvanreijen@gmail.com> docs: add cli demo (openwallet-foundation#619) Signed-off-by: annelein <anneleinvanreijen@gmail.com> fix: check proof request group names do not overlap (openwallet-foundation#638) Signed-off-by: annelein <anneleinvanreijen@gmail.com> fix(core): error if unpacked message does not match JWE structure (openwallet-foundation#639) Signed-off-by: annelein <anneleinvanreijen@gmail.com> feat: filter retrieved credential by revocation state (openwallet-foundation#641) Signed-off-by: Timo Glastra <timo@animo.id> docs: cleanup demo (openwallet-foundation#645) Signed-off-by: Berend Sliedrecht <berend@animo.id> feat(crypto): add abstract KeyPair class Signed-off-by: NB-Karim <karim.northernblock@gmail.com> feat(crypto): move Key class to crypto directory Signed-off-by: NB-Karim <karim.northernblock@gmail.com> feat(crypto): move multiCodecKey to crypto folder Signed-off-by: NB-Karim <karim.northernblock@gmail.com> feat(crypto): add WalletKeyPair Signed-off-by: NB-Karim <karim.northernblock@gmail.com> style: fix formatting issues Signed-off-by: NB-Karim <karim.northernblock@gmail.com> feat: add wallet key derivation method option (openwallet-foundation#650) Signed-off-by: Timo Glastra <timo@animo.id> fix: issue where attributes and predicates match (openwallet-foundation#640) Signed-off-by: annelein <anneleinvanreijen@gmail.com> fix(basic-message): assert connection is ready (openwallet-foundation#657) Signed-off-by: Karim <karim@animo.id> test: minor wallet test changes (openwallet-foundation#660) Signed-off-by: Niall Shaw <niall.shaw@absa.africa> feat: add wallet module with import export (openwallet-foundation#652) Signed-off-by: Timo Glastra <timo@animo.id> refactor(proofs): remove unused method from service (openwallet-foundation#663) Signed-off-by: Timo Glastra <timo@animo.id> fix: agent isinitialized on shutdown (openwallet-foundation#665) Signed-off-by: Niall Shaw <niall.shaw@absa.africa> fix(routing): remove sentTime from request message (openwallet-foundation#670) Signed-off-by: Timo Glastra <timo@animo.id> feat: add w3c credential models Signed-off-by: Karim <karim@animo.id> feat: add mock W3cCredentialService Signed-off-by: Karim <karim@animo.id> feat: keyPair record Signed-off-by: Berend Sliedrecht <berend@animo.id> feat: generic wallet interface for key types Signed-off-by: Timo Glastra <timo@animo.id> fix: renamed secretKey -> privateKey Signed-off-by: Berend Sliedrecht <berend@animo.id> fix: dependency cycles Signed-off-by: Karim <karim@animo.id> feat: KeyPairRepository Signed-off-by: Berend Sliedrecht <berend@animo.id> docs: improved tsdoc for repository Signed-off-by: Berend Sliedrecht <berend@animo.id> feat: restructured wallet api Signed-off-by: Berend Sliedrecht <berend@animo.id> feat: createKey switch Signed-off-by: Berend Sliedrecht <berend@animo.id> feat: added switch to sign and verify Signed-off-by: Berend Sliedrecht <berend@animo.id> style: added tsdoc Signed-off-by: Berend Sliedrecht <berend@animo.id> fix: remove deprecated multibase and multihash (openwallet-foundation#674) Signed-off-by: Timo Glastra <timo@animo.id> feat(crypto): add abstract KeyPair class Signed-off-by: NB-Karim <karim.northernblock@gmail.com> feat(crypto): add WalletKeyPair Signed-off-by: NB-Karim <karim.northernblock@gmail.com> style: fix formatting issues Signed-off-by: NB-Karim <karim.northernblock@gmail.com> feat: add dependency .d.ts files Signed-off-by: Karim <karim@animo.id> feat: implemented create key in wallet Signed-off-by: Berend Sliedrecht <berend@animo.id> Merge branch 'main' into feat/next-signatures feat: implemented sign and verify Signed-off-by: Berend Sliedrecht <berend@animo.id> feat: implementation done, still need record retrieval Signed-off-by: Berend Sliedrecht <berend@animo.id> fix: casing Signed-off-by: Berend Sliedrecht <berend@animo.id> refactor: remove keypairrecord and keypairrepository Signed-off-by: Berend Sliedrecht <berend@animo.id> fix: merge Merge branch 'feat/Ed25519Signature2018' of github.com:animo/aries-framework-javascript into feat/next-signatures Merge branch 'feat/next-signatures' of github.com:animo/aries-framework-javascript into feat/next-signatures feat: finished without test Signed-off-by: Berend Sliedrecht <berend@animo.id> fix(routing): mediation recipient role for recipient (openwallet-foundation#661) Signed-off-by: Timo Glastra <timo@animo.id> refactor(core): renamed BufferEncoder to TypedArrayEncoder (openwallet-foundation#675) Signed-off-by: Berend Sliedrecht <berend@animo.id> feat: add Ed25519Signature2018 Signed-off-by: Karim <karim@animo.id> feat: finished WalletKeyPair implementation Signed-off-by: Karim <karim@animo.id> Merge branch 'main' into feat/W3cCredentialService Merge branch 'main' into feat/next-signatures Merge branch 'feat/next-signatures' into feat/W3cCredentialService fix: do not use basic message id as record id (openwallet-foundation#677) Signed-off-by: Timo Glastra <timo@animo.id> docs: inline and dev docs added Signed-off-by: Berend Sliedrecht <berend@animo.id> Merge remote-tracking branch 'origin' into feat/bbs fix: cleanup Signed-off-by: Berend Sliedrecht <berend@animo.id> fix: using typedarrayencoder now Signed-off-by: Berend Sliedrecht <berend@animo.id> tests: started on IndyWallet test Signed-off-by: Berend Sliedrecht <berend@animo.id> tests: test sign function Signed-off-by: Berend Sliedrecht <berend@animo.id> build(deps): bump minimist from 1.2.5 to 1.2.6 (openwallet-foundation#682) feat: improved tests Signed-off-by: Berend Sliedrecht <berend@animo.id> feat: check if array is typedarray Signed-off-by: Berend Sliedrecht <berend@animo.id> feat: added react native setup Signed-off-by: Berend Sliedrecht <berend@animo.id> docs: updated diff syntax Signed-off-by: Berend Sliedrecht <berend@animo.id> build(deps): bump plist from 3.0.4 to 3.0.5 (openwallet-foundation#683) feat(routing): allow to discover mediator pickup strategy (openwallet-foundation#669) Signed-off-by: Timo Glastra <timo@animo.id> tests: test isTypedArray Signed-off-by: Berend Sliedrecht <berend@animo.id> fix: resolved feedback Signed-off-by: Berend Sliedrecht <berend@animo.id> build: decremented core build version Signed-off-by: Berend Sliedrecht <berend@animo.id> fix: update inbound message validation (openwallet-foundation#678) Changed isPlaintextMessage error handling, and removed logic from isEncryptedMessage Use isValidJweStructure Signed-off-by: Niall Shaw <niall.shaw@absa.africa> feat: add sign method Signed-off-by: Karim <karim@animo.id> Merge branch 'main' into feat/W3cCredentialService feat: added w3c record and repository Signed-off-by: Berend Sliedrecht <berend@animo.id> feat: working repository and record Signed-off-by: Berend Sliedrecht <berend@animo.id> Merge pull request #17 from blu3beri/feat/w3crecord feat(core): w3cCredentialRecord and w3cCredentialRepository fix(core): set tags in MediationRecord constructor (openwallet-foundation#686) Signed-off-by: Ariel Gentile <gentilester@gmail.com> Merge branch 'main' into feat/W3cCredentialService feat: implement verifyCredential Signed-off-by: Karim <karim@animo.id> feat: createPresentation Signed-off-by: Karim <karim@animo.id> feat: implemented SignatureSuiteRegistry Signed-off-by: Karim <karim@animo.id> feat: finish signPres and verifyPres Signed-off-by: Karim <karim@animo.id> refactor: clean-up directory structure Signed-off-by: Karim <karim@animo.id> feat: add BbsBlsSiganture2020 to sig-registry Signed-off-by: Karim <karim@animo.id> Merge branch 'main' into feat/bbs Merge branch 'feat/bbs' into feat/jsonld-credentials feat: implement sign for bbs Signed-off-by: Karim <karim@animo.id> refactor: clean-up W3cCredentialService options Signed-off-by: Karim <karim@animo.id> refactor: switched to mattr jsonld-signatures bbs Signed-off-by: Karim <karim@animo.id> feat: regex for schemaVersion, issuerDid, credDefId, schemaId, schemaIssuerDid (openwallet-foundation#679) Signed-off-by: annelein <anneleinvanreijen@gmail.com> feat: support wallet key rotation (openwallet-foundation#672) Signed-off-by: Mostafa <mostafa.youssef@ontario.ca> feat: add role and method to did record tags (openwallet-foundation#692) Signed-off-by: Timo Glastra <timo@animo.id> feat: delete credential from wallet (openwallet-foundation#691) Signed-off-by: Jan <60812202+janrtvld@users.noreply.github.com> feat: extension module creation (openwallet-foundation#688) Signed-off-by: Ariel Gentile <gentilester@gmail.com> refactor: restructured fixtures and more Signed-off-by: Karim <karim@animo.id> Merge branch 'main' into feat/jsonld-credentials fix: disallow floating promises (openwallet-foundation#704) Signed-off-by: Timo Glastra <timo@animo.id> feat: bbs verification Signed-off-by: Karim <karim@animo.id> Merge branch 'main' into feat/jsonld-credentials refactor: start and stop transports in parallel (openwallet-foundation#705) Signed-off-by: Timo Glastra <timo@animo.id> ci: add yml for postgres setup (openwallet-foundation#703) Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com> fix: did sov service type resolving (openwallet-foundation#689) Signed-off-by: James Ebert <jamesebert.k@gmail.com> test: add test assets Signed-off-by: Karim <karim@animo.id> test(vc): add caching documentLoader for tests Signed-off-by: Karim <karim@animo.id> build(deps): bump async from 2.6.3 to 2.6.4 (openwallet-foundation#710) feat: add update assistant for storage migrations (openwallet-foundation#690) Signed-off-by: Timo Glastra <timo@animo.id> feat: support revocation notification messages (openwallet-foundation#579) Signed-off-by: Patrick Kenyon <treek.kenyon@gmail.com> Co-authored-by: James Ebert <jamesebert.k@gmail.com> fix: disallow floating promises (openwallet-foundation#704) Signed-off-by: Timo Glastra <timo@animo.id> test: add test assets Signed-off-by: Karim <karim@animo.id> test(vc): add caching documentLoader for tests Signed-off-by: Karim <karim@animo.id> Merge branch 'karim/test' into feat/jsonld-credentials refactor: start and stop transports in parallel (openwallet-foundation#705) Signed-off-by: Timo Glastra <timo@animo.id> ci: add yml for postgres setup (openwallet-foundation#703) Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com> fix: did sov service type resolving (openwallet-foundation#689) Signed-off-by: James Ebert <jamesebert.k@gmail.com> build(deps): bump async from 2.6.3 to 2.6.4 (openwallet-foundation#710) feat: add update assistant for storage migrations (openwallet-foundation#690) Signed-off-by: Timo Glastra <timo@animo.id> feat: support revocation notification messages (openwallet-foundation#579) Signed-off-by: Patrick Kenyon <treek.kenyon@gmail.com> Co-authored-by: James Ebert <jamesebert.k@gmail.com> fix: yarn.lock conflict Merge branch 'main' into feat/jsonld-credentials refactor: replace message type constant with string literal (openwallet-foundation#721) Signed-off-by: Jakub Koci <jakub.koci@gmail.com> test: add local did fixtures feat: add credential fetch methods Signed-off-by: Karim <karim@animo.id> feat: add react native documentLoader Signed-off-by: Karim <karim@animo.id> style: fix styling issues (eslint, ts, etc.) Signed-off-by: Karim <karim@animo.id> Merge branch 'main' into feat/jsonld-credentials fix: allow agent without inbound endpoint to connect when using multi-use invitation (openwallet-foundation#712) Previously the session is only stored by the connection id, but this is not always enough for the session to be reused. When using a multi-use invitation the connection id will change while processing the message, meaning the session cannot be reused. This also helps with cases where no connection is established. Fixes openwallet-foundation#483 Signed-off-by: Timo Glastra <timo@animo.id> fix: close session early if no return route (openwallet-foundation#715) This adds a `close` method to all transport sessions so it can be closed from within the agent. This allows us to close the session early if the message doesn't have return routing enabled Signed-off-by: Timo Glastra <timo@animo.id> ci: add node 18 to test matrix (openwallet-foundation#735) Signed-off-by: Timo Glastra <timo@animo.id> feat: pickup v2 protocol (openwallet-foundation#711) Signed-off-by: KolbyRKunz <KolbyKunz@yahoo.com> BREAKING CHANGE: The mediator pickup strategy enum value `MediatorPickupStrategy.Explicit` has been renamed to `MediatorPickupStrategy.PickUpV1` to better align with the naming of the new `MediatorPickupStrategy.PickUpV2` Merge branch 'main' into feat/jsonld-credentials fix: dropped unused dependency Signed-off-by: Karim <karim@animo.id> fix: error typo Co-authored-by: Timo Glastra <timo@animo.id> fix: simplify keyType declaration Co-authored-by: Timo Glastra <timo@animo.id> fix: optional fields in did document (openwallet-foundation#726) Signed-off-by: Timo Glastra <timo@animo.id> fix: dropped ed25519 ctx deps Signed-off-by: Karim <karim@animo.id> fix: removed unused type def Signed-off-by: Karim <karim@animo.id> fix: remove unnecesarry transformer Signed-off-by: Karim <karim@animo.id> fix: broken import Signed-off-by: Karim <karim@animo.id> fix: remove unnecessary W3cCredentialState Signed-off-by: Karim <karim@animo.id> fix: doc typo Co-authored-by: Timo Glastra <timo@animo.id> Signed-off-by: Karim Stekelenburg <karim@animo.id> fix: remove commented code Signed-off-by: Karim <karim@animo.id> fix: remove unnecessary comment Signed-off-by: Karim <karim@animo.id> fix: rename confusing context vs context url Signed-off-by: Karim <karim@animo.id> fix: moved jsonld related types and code to utils file Signed-off-by: Karim <karim@animo.id> fix: replaced inline urls with local constants Signed-off-by: Karim <karim@animo.id> fix: broken imports Signed-off-by: Karim <karim@animo.id> fix: eslint issues Signed-off-by: Karim <karim@animo.id> fix: eslint issues Signed-off-by: Karim <karim@animo.id> fix: remove unnecessary assignment Signed-off-by: Karim <karim@animo.id> fix: replace faulty challenge assignment Signed-off-by: Karim <karim@animo.id> fix: inverted statement Signed-off-by: Karim <karim@animo.id> fix: remove unused revoked options Signed-off-by: Karim <karim@animo.id> fix: uuid challenge and presentation suites Signed-off-by: Karim <karim@animo.id> test: add missing test for bbs verify pres Signed-off-by: Karim <karim@animo.id> refactor: add custom ed25519 2020 to 2018 impl Signed-off-by: Karim <karim@animo.id> fix: unclear variable name Signed-off-by: Karim <karim@animo.id> feat: add issue credential v2 (openwallet-foundation#745) Signed-off-by: Mike Richardson <mike.richardson@northernblock.io> fix: removed unused props from docs Signed-off-by: Karim <karim@animo.id> refactor: rename utilities.ts to bbs-utils.ts Signed-off-by: Karim <karim@animo.id> feat: add additional W3cCredentialRecord tags Signed-off-by: Karim <karim@animo.id> fix: removed duplicate function Signed-off-by: Karim <karim@animo.id> fix: do not import test logger in src (openwallet-foundation#746) Signed-off-by: Timo Glastra <timo@animo.id> fix: do not import from src dir (openwallet-foundation#748) Signed-off-by: Timo Glastra <timo@animo.id> refactor: rewrite conversion method Signed-off-by: Karim Stekelenburg <karim@animo.id> feat: add givenId as W3cCredentialRecord tag Signed-off-by: Karim Stekelenburg <karim@animo.id> fix: convert any types Signed-off-by: Karim Stekelenburg <karim@animo.id> chore!: update indy-sdk-react-native version to 0.2.0 (openwallet-foundation#754) Signed-off-by: Amit <amit@northernblock.io> BREAKING CHANGE: indy-sdk-react-native has been updated to 0.2.0. The new version now depends on libindy version 1.16 and requires you to update the binaries in your react-native application. See the [indy-sdk-react-native](https://github.com/hyperledger/indy-sdk-react-native) repository for instructions on how to get the latest binaries for both iOS and Android. fix: typings Signed-off-by: Karim Stekelenburg <karim@animo.id> fix: typings Signed-off-by: Karim <karim@animo.id> fix: typings & drop jsonld bbs dep Signed-off-by: Karim <karim@animo.id> fix: remove commented code Signed-off-by: Karim <karim@animo.id> fix: typing and faulty context Signed-off-by: Karim <karim@animo.id> fix: remove keyAgreement Signed-off-by: Karim <karim@animo.id> fix: remove unused typing file Signed-off-by: Karim <karim@animo.id> fix: rename map variable Signed-off-by: Karim <karim@animo.id> fix: use w3cDate Signed-off-by: Karim <karim@animo.id> fix: rename map variable Signed-off-by: Karim <karim@animo.id> style: clean map syntax Signed-off-by: Karim <karim@animo.id> fix: typo Signed-off-by: Karim <karim@animo.id> fix: remove commented code Signed-off-by: Karim <karim@animo.id> feat(core): add support for postgres wallet type (openwallet-foundation#699) Signed-off-by: Sai Ranjit Tummalapalli <sairanjit.tummalapalli@ayanworks.com> Co-authored-by: Timo Glastra <timo@animo.id> fix: add g1 and g2 contexts Signed-off-by: Karim <karim@animo.id> fix: add X25519 contexts Signed-off-by: Karim <karim@animo.id> fix(node): allow to import node package without postgres (openwallet-foundation#757) Signed-off-by: Timo Glastra <timo@animo.id> fix: mediation record checks for pickup v2 (openwallet-foundation#736) Signed-off-by: Timo Glastra <timo@animo.id> Merge branch 'main' into feat/jsonld-credentials fix: Key imports Signed-off-by: Karim <karim@animo.id> fix: change invalid g1 g2 contexts to bbs Signed-off-by: Karim <karim@animo.id> fix: remove invalid contexts Signed-off-by: Karim <karim@animo.id> fix: delete credentials (openwallet-foundation#766) Signed-off-by: Mike Richardson <mike.richardson@northernblock.io> fix: various Signed-off-by: Karim <karim@animo.id> test: do not use indy ledgers in wallet test Signed-off-by: Timo Glastra <timo@animo.id> fix: add jsonld.expand typedef Signed-off-by: Karim <karim@animo.id> Merge branch 'main' into feat/jsonld-credentials fix: add additional typedefs Signed-off-by: Karim <karim@animo.id> feat: add out-of-band and did exchange (openwallet-foundation#717) Signed-off-by: Jakub Koci <jakub.koci@gmail.com> Co-authored-by: Timo Glastra <timo@animo.id> BREAKING CHANGE: the connections module has been extended with an out of band module and support for the DID Exchange protocol. Some methods have been moved to the out of band module, see [Migrating from AFJ 0.1.0 to 0.2.x](https://github.com/hyperledger/aries-framework-javascript/blob/main/docs/migration/0.1-to-0.2.md) for detailed migration instructions. feat: support handling messages with different minor version (openwallet-foundation#714) Signed-off-by: Timo Glastra <timo@animo.id> fix: relax validation of thread id in revocation notification (openwallet-foundation#768) Signed-off-by: Blazej Marcinkiewicz <marcinkiewicz@procivis.ch> fix: typing issues with jsonld Signed-off-by: Timo Glastra <timo@animo.id> feat: ability to add generic records (openwallet-foundation#702) feat: extension module creation (openwallet-foundation#688) Co-authored-by: Berend Sliedrecht <berend@animo.id> Co-authored-by: Timo Glastra <timo@animo.id> Merge pull request #21 from TimoGlastra/fix/jsonld-types-issues fix: typing issues with jsonld fix: propose payload attachment in in snake_case JSON format (openwallet-foundation#775) Signed-off-by: Mike Richardson <mike.richardson@northernblock.io> fix: typing issues Signed-off-by: Karim <karim@animo.id> fix: delete credentials (openwallet-foundation#770) Signed-off-by: Mike Richardson <mike.richardson@northernblock.io> fix: type issues Signed-off-by: Karim <karim@animo.id> test: use event listener instead of while loop (openwallet-foundation#778) Signed-off-by: Timo Glastra <timo@animo.id> feat: bbs createKey, sign and verify (openwallet-foundation#684) Signed-off-by: Berend Sliedrecht <berend@animo.id> Merge branch '0.3.0-pre' into feat/jsonld-credentials

morrieinmaas requested a review from a team as a code owner December 14, 2021 13:58

morrieinmaas force-pushed the feat/generic-attachment-handler branch from 31cac90 to 92acbb6 Compare December 14, 2021 14:46

morrieinmaas changed the title ~~wip: feat: generic attachment handler~~ feat: generic attachment handler Dec 15, 2021

morrieinmaas force-pushed the feat/generic-attachment-handler branch from 4c58e5a to eed46e3 Compare December 15, 2021 11:33

berendsliedrecht reviewed Dec 15, 2021

View reviewed changes

TimoGlastra requested changes Dec 15, 2021

View reviewed changes

feat: generic attachment handler

5dd353b

fixed fct declaration and henceforth tests Co-authored-by: annelein <anneleinvanreijen@gmail.com> Signed-off-by: morrieinmaas <moritz@animo.id>

morrieinmaas force-pushed the feat/generic-attachment-handler branch from eed46e3 to 5dd353b Compare December 15, 2021 12:04

morrieinmaas requested review from TimoGlastra and berendsliedrecht December 15, 2021 12:09

Merge branch 'main' into feat/generic-attachment-handler

2c4c442

feat: generic attachment handler

c743be2

Signed-off-by: annelein <anneleinvanreijen@gmail.com>

berendsliedrecht reviewed Dec 15, 2021

View reviewed changes

morrieinmaas added 2 commits December 16, 2021 10:51

chore: address code review feedback

74558ec

Better typing/function signatures Co-authored-by: annelein <anneleinvanreijen@gmail.com> Signed-off-by: morrieinmaas <moritz@animo.id>

chore: merge remote

8df7f43

Merge branch 'feat/generic-attachment-handler' of github.com:morrieinmaas/aries-framework-javascript into feat/generic-attachment-handler Signed-off-by: morrieinmaas <moritz@animo.id>

morrieinmaas requested a review from berendsliedrecht December 16, 2021 09:54

berendsliedrecht approved these changes Dec 16, 2021

View reviewed changes

Merge branch 'main' into feat/generic-attachment-handler

2fe98dd

TimoGlastra approved these changes Dec 16, 2021

View reviewed changes

TimoGlastra merged commit 4d7d3c1 into openwallet-foundation:main Dec 16, 2021

karimStekelenburg mentioned this pull request May 19, 2022

4f07f11304dd1d1b75af3d0274dae29a906b9fd9: Karim <karim@animo.id> #783

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: generic attachment handler #578

feat: generic attachment handler #578

morrieinmaas commented Dec 14, 2021 •

edited

Loading

morrieinmaas commented Dec 15, 2021

berendsliedrecht Dec 15, 2021 •

edited

Loading

morrieinmaas Dec 15, 2021

morrieinmaas Dec 15, 2021

berendsliedrecht Dec 15, 2021

TimoGlastra left a comment

TimoGlastra Dec 15, 2021

TimoGlastra Dec 15, 2021

TimoGlastra Dec 15, 2021

TimoGlastra Dec 15, 2021

morrieinmaas Dec 15, 2021

codecov-commenter commented Dec 15, 2021 •

edited

Loading

berendsliedrecht Dec 15, 2021

berendsliedrecht Dec 15, 2021

morrieinmaas Dec 15, 2021

morrieinmaas Dec 15, 2021

berendsliedrecht Dec 15, 2021

morrieinmaas Dec 16, 2021

berendsliedrecht Dec 15, 2021

morrieinmaas Dec 15, 2021

morrieinmaas commented Dec 16, 2021

TimoGlastra left a comment

morrieinmaas commented Dec 16, 2021

	if (this.base64 !== null && typeof this.base64 === 'string') {
	if (this.base64 && typeof this.base64 === 'string') {

	const credentialJson = attachment?.data ? attachment.data.getDataAsJson() : null
	const credentialJson = attachment?.data?.getDataAsJson()


		return credentialOfferJson
		return credentialOfferJson as CredOffer

feat: generic attachment handler #578

feat: generic attachment handler #578

Conversation

morrieinmaas commented Dec 14, 2021 • edited Loading

morrieinmaas commented Dec 15, 2021

berendsliedrecht Dec 15, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TimoGlastra left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Dec 15, 2021 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

morrieinmaas commented Dec 16, 2021

TimoGlastra left a comment

Choose a reason for hiding this comment

morrieinmaas commented Dec 16, 2021

morrieinmaas commented Dec 14, 2021 •

edited

Loading

berendsliedrecht Dec 15, 2021 •

edited

Loading

codecov-commenter commented Dec 15, 2021 •

edited

Loading