fix: invalid injection symbols in W3cCredService #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karim <karim@animo.id>
NB-MikeRichardson
approved these changes
May 20, 2022
berendsliedrecht
approved these changes
May 20, 2022
|
How has this not broken the tests? Is it because the W3CCredentialService is not injected anywhere currently? |
NB-MikeRichardson
added a commit
to NB-MikeRichardson/aries-framework-javascript
that referenced
this pull request
May 23, 2022
fix: invalid injection symbols in W3cCredService (openwallet-foundation#786)
karimStekelenburg
added a commit
that referenced
this pull request
May 24, 2022
Signed-off-by: Karim <karim@animo.id>
TimoGlastra
pushed a commit
that referenced
this pull request
May 26, 2022
Signed-off-by: Karim <karim@animo.id>
TimoGlastra
pushed a commit
that referenced
this pull request
May 31, 2022
Signed-off-by: Karim <karim@animo.id>
TimoGlastra
pushed a commit
that referenced
this pull request
Jun 3, 2022
Signed-off-by: Karim <karim@animo.id>
TimoGlastra
pushed a commit
that referenced
this pull request
Jun 10, 2022
Signed-off-by: Karim <karim@animo.id>
TimoGlastra
pushed a commit
that referenced
this pull request
Jun 15, 2022
Signed-off-by: Karim <karim@animo.id>
TimoGlastra
pushed a commit
that referenced
this pull request
Jun 15, 2022
Signed-off-by: Karim <karim@animo.id>
TimoGlastra
pushed a commit
that referenced
this pull request
Jun 17, 2022
Signed-off-by: Karim <karim@animo.id>
TimoGlastra
pushed a commit
that referenced
this pull request
Jun 30, 2022
Signed-off-by: Karim <karim@animo.id>
TimoGlastra
pushed a commit
that referenced
this pull request
Jul 3, 2022
Signed-off-by: Karim <karim@animo.id>
TimoGlastra
pushed a commit
that referenced
this pull request
Jul 4, 2022
Signed-off-by: Karim <karim@animo.id>
TimoGlastra
pushed a commit
that referenced
this pull request
Aug 11, 2022
Signed-off-by: Karim <karim@animo.id>
TimoGlastra
pushed a commit
that referenced
this pull request
Aug 26, 2022
Signed-off-by: Karim <karim@animo.id>
TimoGlastra
pushed a commit
that referenced
this pull request
Aug 26, 2022
Signed-off-by: Karim <karim@animo.id>
|
It broke my tests!
…________________________________
From: Timo Glastra ***@***.***>
Sent: 20 May 2022 16:57
To: hyperledger/aries-framework-javascript ***@***.***>
Cc: Mike Richardson ***@***.***>; Comment ***@***.***>
Subject: Re: [hyperledger/aries-framework-javascript] fix: invalid injection symbols in W3cCredService (PR #786)
How has this not broken the tests? Is it because the W3CCredentialService is not injected anywhere currently?
—
Reply to this email directly, view it on GitHub<#786 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWM6GLPEQQCL3BC7VZFUBUDVK6K4FANCNFSM5WPMPDRQ>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed invalid injection symbols for Wallet and Logger in the W3cCredentialService.
Signed-off-by: Karim karim@animo.id