Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oob): support legacy prefix in attachments #931

Conversation

TimoGlastra
Copy link
Contributor

Fix issue of the oob module not being able to handle the legacy did sov prefix on attachment in oob invitations.

Issue as reported on discord:

AFJ is throwing an error when i accept an oob invitation with a present-proof/credential-offer attachment from acapy, Error msg: There is no message in requests~attach supported by agent. It's due to LegacyDidSovPrefix in the message type. It fails at this step : https://github.com/hyperledger/aries-framework-javascript/blob/main/packages/core/src/modules/oob/OutOfBandModule.ts#L599

Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra TimoGlastra requested a review from a team as a code owner July 5, 2022 13:22
@TimoGlastra TimoGlastra added this to the v0.2.1 milestone Jul 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2022

Codecov Report

Merging #931 (ffe91c8) into main (9e30bb2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #931   +/-   ##
=======================================
  Coverage   87.73%   87.74%           
=======================================
  Files         475      475           
  Lines       11349    11354    +5     
  Branches     1875     1879    +4     
=======================================
+ Hits         9957     9962    +5     
  Misses       1325     1325           
  Partials       67       67           
Impacted Files Coverage Δ
packages/core/src/modules/oob/OutOfBandModule.ts 87.59% <100.00%> (+0.09%) ⬆️
packages/core/src/utils/messageType.ts 97.82% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e30bb2...ffe91c8. Read the comment docs.

Copy link
Contributor

@morrieinmaas morrieinmaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@TimoGlastra TimoGlastra merged commit 82863f3 into openwallet-foundation:main Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants