-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC 0036 and 0037: remove mime-type and encoding from previews? #190
Comments
These came about from the solution for JIRA IS-1281, where Mr. Daniel Hardman was interested in passing large binary objects as credential values. MIME TYPE: Similarly, in negotiating with a prover proposing a binary attribute, the verifier must be able to render it (e.g., a picture for facial recognition) to judge its applicability. As is, MIME type defaults to text/plain; implementations that don't use it can leave it out. ENCODING As is, encoding defaults to no encoding; implementations that don't use it can leave it out.. OPTIONS |
That's funny that I'm being so inconsistent. Good catch. :-) I don't want to scrap the work you did on embedded photos and such in credentials. It was a wonderful contribution. We need it. However, I do think the preview as currently structured isn't modeling the issue correctly. The need seems to be:
Most fields in credentials are going to be numbers, strings, or dates--not embedded photos. So adding a mime type and encoding for all attributes, just to cover the corner case of embedded photos, doesn't seem right. A number is not compatible with the MIME type "text/plain", so that's not an acceptable default, either. What if we did something like this:
|
I see the PR for this has gone through. Can we close this issue now? |
Yup. |
I'm concerned about the use of
mime-type
andencoding
in previews. The vast majority of properties in credentials should be scalar values (strings or integers or floats or dates). There are no mime types for such things, AFAIK (text/plain is given as a default value; do any other values make sense?). So having a property namedmime-type
doesn't make sense to me. I'm not sure thatencoding
makes any sense, either. We don't give any meaningful guidance about values for the property, other than to say that its default isnull
. If we meanencoding
in the way that Indy means it, do we need to say that?@sklump @swcurran @kdenhartog
The text was updated successfully, but these errors were encountered: