-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move vdrtools fork under aries-vcx repo #724
Comments
No immediate issues come to mind - could be a good move if the plan is to move away from vdrtools. Will be convenient with some of the dependency issues we know we'll likely have to solve. I'd be interested to see how IDEs perform with this change. I wonder if it will impact performance having the giant vdrtools repo 'open' at all times when working in the aries-vcx workspace? |
I am confident M1 users won't notice ;-) But on slower machines, I guess depends on IDE, both performance and possible solutions. in InteliJ for example you can |
I'd like to suggest moving the fork of vdr-tools into this repo. We currently using fork of vdrtools, eg:
https://github.com/hyperledger/aries-vcx/blob/0.50.0/aries_vcx/Cargo.toml#L40
Given good developments toward credex libs migration and commitment to drop usage of libindy/vdrtools in 2023, in combo with the fact there's no updates for the library from Evernym https://gitlab.com/evernym/verity/vdr-tools I think we can continue taking lead within our fork, but move the development here, rather than having it externalized and less transparent on some gitlab repo.
As underlying code for holder, prover, verifier works with credex libraries, large portions of the vdr-tools codebase can technically be deleted today (with some updates to libvcx codebase to start using credex/indy-vdr codepaths by default). By the end of the journey, the only thing which should be left out of vdrtools is wallet implementation, which might be then superseded (or might be used interchangeably) by (or with) Aries Askar.
Additionally having git dependency would become a problem once we attempt to publish aries-vcx as crate (this was touched on at the last aries-vcx call)
@mirgee @gmulhearn what do you think?
The text was updated successfully, but these errors were encountered: