Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading error message when Besu cannot create parent directories #552

Closed
MadelineMurray opened this issue Mar 22, 2020 · 3 comments
Closed
Labels
bug Something isn't working docker good first issue Good for newcomers icebox items that need more consideration, time, or can wait P4 Low (ex: Node doesn't start up when the configuration file has unexpected "end-of-line" character)

Comments

@MadelineMurray
Copy link
Contributor

When starting Besu will create a directory if the parent directories already exist but will not create parent directories. This is standard behavior that we do not want to change but a better error message would be helpful.

If parent directories are specified that do not exist, startup fails with the following error:

Cannot store generated private key.

This error message should indicate the actual issue:
Cannot create multiple directories for $path

Probability: Remote
Severity: Marginal

@MadelineMurray MadelineMurray added bug Something isn't working good first issue Good for newcomers labels Mar 22, 2020
@MadelineMurray
Copy link
Contributor Author

Since raising this, it appears Besu does create multiple directories in some cases which is not the behaviour we want. ie, the following creates the three directories and the database inside dir3
besu --network=dev --data-path=dir1/dir2/dir3

@timbeiko timbeiko added the P4 Low (ex: Node doesn't start up when the configuration file has unexpected "end-of-line" character) label May 20, 2020
@holiman
Copy link

holiman commented Sep 11, 2020

This also happens in other circumstances, notably when running in docker.

It's the "Correct Way To Do It" that besu doesn't use the root user within the docker image, but if the mounted datadir is non-writeable by the besu inside-docker user, then this error happens aswell.

@RatanRSur RatanRSur removed the good first issue Good for newcomers label May 19, 2021
@sajz sajz added the good first issue Good for newcomers label Jun 1, 2021
@garyschulte garyschulte assigned jflo and unassigned jflo and garyschulte Jun 21, 2021
@non-fungible-nelson non-fungible-nelson added the icebox items that need more consideration, time, or can wait label May 24, 2022
@iamhsk iamhsk added the TeamChupa GH issues worked on by Chupacabara Team label Jul 14, 2022
@macfarla macfarla removed the TeamChupa GH issues worked on by Chupacabara Team label Jul 22, 2024
@pullurib
Copy link
Contributor

pullurib commented Oct 4, 2024

This also happens in other circumstances, notably when running in docker.

It's the "Correct Way To Do It" that besu doesn't use the root user within the docker image, but if the mounted datadir is non-writeable by the besu inside-docker user, then this error happens aswell.

This should now be fixed by #7575 which sets permissions for data path inside docker image . Should this be issue be closed now ?

@jflo jflo added the docker label Oct 15, 2024
@macfarla macfarla closed this as completed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docker good first issue Good for newcomers icebox items that need more consideration, time, or can wait P4 Low (ex: Node doesn't start up when the configuration file has unexpected "end-of-line" character)
Projects
None yet
Development

No branches or pull requests