New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto - migrate tests from Junit4 to Junit5 #5568

Closed

macfarla opened this issue Jun 9, 2023 · 1 comment · Fixed by #6234 or #6280

Assignees

Labels

good first issue TeamRevenant testing

Contributor

macfarla commented Jun 9, 2023

Module crypto
eg
public class HashTest

Add dependency for junit.jupiter (junit5)
Migrate per https://blogs.oracle.com/javamagazine/post/migrating-from-junit-4-to-junit-5-important-differences-and-benefits
Remove dependency on junit 4

Here's an example https://github.com/hyperledger/besu/pull/5525/files

macfarla added good first issue TeamRevenant testing labels

7suyash7 mentioned this issue

Migrate crypto tests from JUnit 4.0 to JUnit 5.0 #5574

Closed

Contributor

7suyash7 commented Jun 9, 2023

Hey @macfarla, if you could take a look at my PR that would be great! I plan to migrate tests for other folders as well

macfarla self-assigned this

macfarla mentioned this issue

crypto migrate to junit 5 #6234

Merged

macfarla closed this as completed in #6234

macfarla mentioned this issue

[MINOR] migrate remaining Crypto tests to junit 5 #6280

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment