Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining Hive Cancun Failures #6554

Closed
spencer-tb opened this issue Feb 9, 2024 · 2 comments · Fixed by #6582
Closed

Remaining Hive Cancun Failures #6554

spencer-tb opened this issue Feb 9, 2024 · 2 comments · Fixed by #6582
Assignees
Labels
RPC TeamRevenant GH issues worked on by Revenant Team

Comments

@spencer-tb
Copy link
Contributor

Description

I'm tagging the last 3 failures here for the hive cancun tests.
(note: on hivecancun all other failures pass locally and are due to something internal to the CI).

Specifically from the engine-cancun simulator.

ForkchoiceUpdatedV3 To Request Shanghai Payload, Null Beacon Root
ForkchoiceUpdatedV2 To Request Shanghai Payload, Non-Null Beacon Root
ForkchoiceUpdatedV2 To Request Cancun Payload, Non-Null Beacon Root

These can all be explained from the execution apis spec update in ethereum/execution-apis#498.
We are essentially sending an fcu with invalid payload attributes and hence expect an error reponse of INVALID_PAYLOAD_ATTRIBUTES. Besu is returning INVALID_PARAMS. Should be a simple parameter fix.

Steps to reproduce

Using the latest version of hive run the following command:

./hive --sim ethereum/engine --client besu --client-file configs/cancun.yaml --docker.output --sim.limit engine-cancun/"<test_name>"
@macfarla
Copy link
Contributor

@jflo are you on this one already?

@jframe jframe added the RPC label Feb 15, 2024
@macfarla macfarla added the TeamRevenant GH issues worked on by Revenant Team label Feb 15, 2024
@macfarla
Copy link
Contributor

thanks @spencer-tb - all should be passing in the next run!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RPC TeamRevenant GH issues worked on by Revenant Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants