Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD improvements #6695

Closed
jflo opened this issue Mar 7, 2024 · 0 comments · Fixed by #6705
Closed

CI/CD improvements #6695

jflo opened this issue Mar 7, 2024 · 0 comments · Fixed by #6705
Labels
dev experience The build system, things that enable easier development etc.

Comments

@jflo
Copy link
Contributor

jflo commented Mar 7, 2024

The following gaps have been identified and need to be addressed:

  1. Deferred tests do not prevent merging into main, as expected. Since an action run that is skipped by a conditional is considered "successful", the approval checking steps in our workflows are actually passing the check before the test has run. Suggest simply running all tests on PR update, as CircleCI did and refactoring later to re-implement deferral.
  2. Subsequent updates to a branch with a PR do not cancel any in-flight executions.
  3. A constantly built artifact is needed for nightly updates to automated canaries.
  4. CodeQL workflow is very expensive, it can be run nightly on main or manually.
@jflo jflo mentioned this issue Mar 8, 2024
8 tasks
@non-fungible-nelson non-fungible-nelson added the dev experience The build system, things that enable easier development etc. label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev experience The build system, things that enable easier development etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants