Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p2p-host config leak #7721

Closed
siladu opened this issue Oct 4, 2024 · 0 comments · Fixed by #7725
Closed

p2p-host config leak #7721

siladu opened this issue Oct 4, 2024 · 0 comments · Fixed by #7725
Assignees
@macfarla
Labels
bug Something isn't working

Comments

@siladu
Copy link
Contributor

siladu commented Oct 4, 2024 •
edited
Loading

Pointed out by @seamonkey82 on discord.

Current master attempts to open --metrics-port on the --p2p-host address.

I have verified the bug was introduced in f4dc48d

To recreate...

 $BESU --p2p-host=9.9.9.9
...
2024-10-04 11:34:28.916+10:00 | main | INFO  | EngineJsonRpcService | Starting JSON-RPC service on 9.9.9.9:8551

By default we start JSON-RPC service for engine API on 127.0.0.1. The bug means setting p2p-host is overwriting other host configs.

When you specify the relevant host, that correctly takes precedence...

$BESU --rpc-http-host=1.1.1.1 --p2p-host=9.9.9.9
2024-10-04 11:40:22.499+10:00 | main | INFO  | EngineJsonRpcService | Starting JSON-RPC service on 1.1.1.1:8551
@siladu siladu added the bug Something isn't working label Oct 4, 2024
@macfarla macfarla self-assigned this Oct 4, 2024
@macfarla macfarla mentioned this issue Oct 4, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@macfarla macfarla

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add correct default to rpcHost macfarla/besu
2 participants
@macfarla @siladu